Bug#667984: libgtop2: FTBFS(kfreebsd): __printflike undefined

[Steven Chamberlain]

tags 667984 + patch
thanks

On 07/04/12 21:35, Robert Millan wrote:
> This section of <sys/conf.h> is protected by "#ifdef _KERNEL".
> 
> It means something in userland is defining that macro. That's very
> wrong! _KERNEL is only supposed to be defined when building kernel
> image or modules.

Thanks for explaining.

libgtop2's sysdeps/freebsd/procmap.c defines _KERNEL, to be able to
include sys/pipe.h, but doesn't undef it before including sys/conf.h
(cdefs gets included within sys/conf.h > eglibc's param.h > limits.h).

I don't see why libgtop2 needs sys/pipe.h at all;  it seems to build
okay without, and it's not meant to be used anyway in userland since 2005:

http://svnweb.freebsd.org/base?view=revision&revision=132478

Regards,
-- 
Steven Chamberlain
steven at pyro.eu.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 06_kfreebsd_sys_pipe.diff
Type: text/x-patch
Size: 885 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20120407/705021d4/attachment-0003.bin>