Bug#677235: gnome-sushi: please update to use libmusicbrainz5

[Jon Dowland]

On Wed, Jun 13, 2012 at 10:08:59AM +0100, Jon Dowland wrote:
> For some reason for most of the music I have on my laptop, the tracks are
> linked to a single release which is a bootleg of some sort (examples [1,2])
> which has scant metadata, in particular no ASINs.

Figured it out.

The sushi code is written to support receiving multiple matches for its query
to MB: it loops through and picks the first match which has an ASIN.

However, when the actual query is made, the limit on responses is set to one,
so only one result is ever returned.

In the case of many albums, there are multiple matches, sometimes with bootlegs
or just with records which aren't fleshed out with an ASIN.

This simple patch cures the issue for me for the albums I've tested. Would you
consider it in the Debian package? (about to submit upstream):

diff --git a/src/libsushi/sushi-cover-art.c b/src/libsushi/sushi-cover-art.c
index 5869ae1..f171884 100644
--- a/src/libsushi/sushi-cover-art.c
+++ b/src/libsushi/sushi-cover-art.c
@@ -229,7 +229,7 @@ fetch_uri_job (GIOSchedulerJob *sched_job,
   param_values[0] = g_strdup_printf ("artist:\"%s\" AND release:\"%s\"", job->a
 
   param_names[1] = g_strdup ("limit");
-  param_values[1] = g_strdup ("1");
+  param_values[1] = g_strdup ("10");
 
   param_names[2] = NULL;
   param_values[2] = NULL;