Bug#631729: irssi-plugin-xmpp: Memory corruption and crash with /xmppconnect

[Michael Stapelberg]

tags 631729 + patch
thanks

Hi,

I used “nc -4 -l -p 5222” to simulate a local jabber server, then
started irssi, used /load xmpp and /xmppconnect -h localhost f at b to
trigger the issue.

Attached you can find the patch with which I have come up. Here is the
description:

 Previously, loudmouth would set socket->watch_connect to NULL when
 encountering an error. When the connection attempt (to a different
 IPv6) succeeded later on, _lm_socket_succeeded would therefore not
 remove the socket_connect_cb watcher, leading to socket_connect_cb
 being called upon socket activity and segfaulting the program.

This patch fixes the issue for me, but I don’t use irssi-plugin-xmpp
normally, so testing/review is welcome.

-- 
Best regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-ipv6-connect.patch
Type: text/x-patch
Size: 1113 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20130128/303da79e/attachment-0001.bin>