Bug#683338: gdm3: no prompt anymore after login cancel using disable_user_list

[Sébastien Villemot]

Control: tags -1 + confirmed patch

Le mercredi 29 mai 2013 à 18:55 +0530, shirish शिरीष a écrit :

> I have been having the same issue as Salvatore Bonaccorso even though
> mine is gdm:3.6.1-2 version and not gdm3.4.1-8 .

I confirm the bug in both wheezy and sid (with disable_user_list=true).

Here is an analysis of the bug:

- when the user clicks "Cancel", a D-Bus signal is emitted, which leads
to the function gdm_greeter_login_window_reset() being called

- this latter function calls reset_dialog_after_messages(), and then
restarts all extensions

- the problem is that there are pending messages, which will be
processed before calling reset_dialog(); therefore the reset_dialog()
function is actually called *after* the extensions have been restarted

- since the reset_dialog() calls reset_extension() on all extensions,
those are left in a disabled state, and the authentication does not
start

I attach a patch that solves the problem in a minimalistic way, with no
risk of breaking anything else. Maybe there is a better way of solving
the problem by refactoring the logic, but I could not figure it.

Joss: can you please review the patch? If you agree with it, I would
like to fix the bug in wheezy (which means first fixing it in sid).

> "But the problem does not seem only present when disabling the user
> listing. Even with disable_user_list=false, after cancelling a login,
> the greeter gets confused and it's not possible anymore to scroll the
> user list shown." - Salvatore Bonaccorso

When disable_user_list=false, there is indeed also a problem, but this
is a different issue. It only affects sid (not wheezy), and I guess it
is related to GTK+ 3.8.

-- 
 .''`.    Sébastien Villemot
: :' :    Debian Developer
`. `'     http://www.dynare.org/sebastien
  `-      GPG Key: 4096R/381A7594

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug683338.diff
Type: text/x-patch
Size: 2573 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20130615/735012e0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20130615/735012e0/attachment.sig>