Bug#727174: pango1.0 FTBFS with glib2.0 (>= 2.37.2), G_TEST_SRCDIR undefined

[Steve Langasek]

Package: pango1.0
Version: 1.36.0-1
Severity: serious
Tags: patch experimental
Justification: FTBFS
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu trusty ubuntu-patch

Hi folks,

The pango1.0 package in unstable fails to build from source with the version
of glib2.0 in experimental, because with newer glib2.0 pango makes use of a
new API called "g_test_get_filename" which relies on G_TEST_SRCDIR being set
in the environment - but nothing in the build system is setting this. 
Perhaps this is expected to be set by a newer version of automake/autoconf
rules bundled with glib, and the pango tarball was built without a new
enough version?  I'm not sure; in any case, I've worked around this in
Ubuntu by just setting G_TEST_SRCDIR to the correct value to let the package
build.

In the process of debugging this, I also found that the package's 'clean'
target didn't work correctly, failing to clean up either the debian/build
tree or the debian/install tree.  So the attached patch includes a fix-up
for this as well.

Corresponding changelog entry:

  * debian/rules: export G_TEST_SRCDIR to work around upstream brokenness
    when building with glib2.0 (>= 2.37.2): the source code expects this
    variable to be set, but nothing exports it in the build system.
  * debian/rules: remove the build and install dirs when we're done, so that
    debian/rules clean works correctly.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pango1.0_1.36.0-1ubuntu1.debdiff
Type: text/x-diff
Size: 803 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20131022/98ec41fa/attachment.diff>