Bug#721886: FTBFS on kfreebsd-*: glibtop_machine.h:26:19: fatal error: nlist.h: No such file or directory

[Michael Biebl]

tags 721886 + help
thanks

Am 05.09.2013 23:08, schrieb Guillem Jover:
> Hi!
> 
> On Thu, 2013-09-05 at 19:52:13 +0200, Michael Biebl wrote:
>> Am 05.09.2013 19:42, schrieb Julien Cristau:
>>> On Thu, Sep  5, 2013 at 19:40:18 +0200, Michael Biebl wrote:
>>>> Am 05.09.2013 19:29, schrieb Julien Cristau:
>>>>> On Thu, Sep  5, 2013 at 17:50:18 +0200, Michael Biebl wrote:
>>>>>> Am 05.09.2013 17:29, schrieb Robert Millan:
>>>>>>> -#include <nlist.h>
>>>>>>> +#include <bsd/nlist.h>
> 
> Please try to avoid this, which cannot be easily upstreamed, or if it
> can be upstreamed it unnecessarily pollutes the source.
> 
>>>>>> Does that also work with FreeBSD so can be pushed upstream?
>>>>>> Apparently libgtop2 has native FreeBSD support and I wonder if nslist.h
>>>>>> is using a different location on  FreeBSD.
>>>>>>
>>>>> In xorg-server added `pkg-config --cflags libbsd-overlay` to CPPFLAGS
>>>>> from debian/rules.  Lets the code expecting bsd headers on bsd work
>>>>> without patching.
> 
> Yes, that's the ideal solution, which generally avoids any patching.
> 

[..]

Thanks for the explanation. So I went ahead and used the CPPFLAGS
override trick. libgtop2 still fails to build though:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../..
-I../../sysdeps/freebsd -I../../include -I/usr/include/glib-2.0
-I/usr/lib/x86_64-kfreebsd-gnu/glib-2.0/include -isystem
/usr/include/bsd -DLIBBSD_OVERLAY -Winline -Wall -std=gnu89
-Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes
-Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -g -O2
-fstack-protector --param=ssp-buffer-size=4 -Wformat
-Werror=format-security -Wall -c procmem.c  -fPIC -DPIC -o .libs/procmem.o
In file included from procmem.c:36:0:
/usr/include/sys/vnode.h:41:27: fatal error: sys/rangelock.h: No such
file or directory
 #include <sys/rangelock.h>

I don't really have any more time to investigate this any further, so it
would be great if a kfreebsd porter could provide a *tested* patch, i.e.
one which not only makes the package build successfully but ideally also
has some runtime testing which ensures that the package actually works
on kfreebsd.

>> Apparently libgtop2 built just fine in the past with libbsd-dev, so this
>> looks like a recent regression in that package.
> 
> I went over any package explicitly declaring a Build-Depends on
> libbsd-dev when I did those changes, if libgtop2 is directly using
> stuff from libbsd-dev but not declaring it explicitly, that's hardly
> my fault? :)

Fair enough. Will add an explicit build-depends with the next upload.

Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20130906/1df2af80/attachment-0001.sig>