Bug#758465: [libproxy] Explicitly build-depend on zlib

[Peter Pentchev]

Source: libproxy
Version: 0.4.11-4
Severity: minor
Tags: patch

Hi,

While looking at the libproxy source for another reason related to
the "Bootstrappable Debian" GSoC project (two more suggested patches
coming up), I noticed that the libmodman test suite tries to link
against zlib.  IMHO it's good practice to explicitly build-depend on any
non-essential packages used during the build, even if they are pulled in
indirectly by other dependencies.  So what do you think about the
attached patch that adds zlib1g-dev to the list of build dependencies of
libproxy, just to make absolutely certain that it will be there?

If anything should go wrong with this e-mail, the patches are also
available in my Gitorious repository:

https://gitorious.org/roam-debian-bootstrap/libproxy-debian/commits/roam-zlib

Thanks for your work on libproxy!

G'luck,
Peter

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
From b366069db52c1b10a6e1dac4ccc41f595f86c3a6 Mon Sep 17 00:00:00 2001
From: Peter Pentchev <roam at ringlet.net>
Date: Sat, 2 Aug 2014 01:55:46 +0300
Subject: [PATCH 1/2] Explicitly build-depend on zlib.

It's used in the libmodman tests.
---
 debian/control.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/control.in b/debian/control.in
index 06368c1..e36f5e7 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -8,6 +8,7 @@ Build-Depends: debhelper (>= 9),
                gnome-pkg-tools,
                netbase,
                cmake,
+               zlib1g-dev,
                python-all-dev (>= 2.6.6-3~),
                network-manager-dev [linux-any],
                libdbus-1-dev,
-- 
2.1.0.rc1

-------------- next part --------------
From 5a6044df7c400f7b385ba6f57fe66173396deae5 Mon Sep 17 00:00:00 2001
From: Peter Pentchev <roam at ringlet.net>
Date: Sat, 2 Aug 2014 01:56:20 +0300
Subject: [PATCH 2/2] Regenerate the control file.

---
 debian/control | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/control b/debian/control
index ef270b3..cc432f1 100644
--- a/debian/control
+++ b/debian/control
@@ -13,6 +13,7 @@ Build-Depends: debhelper (>= 9),
                gnome-pkg-tools,
                netbase,
                cmake,
+               zlib1g-dev,
                python-all-dev (>= 2.6.6-3~),
                network-manager-dev [linux-any],
                libdbus-1-dev,
-- 
2.1.0.rc1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20140817/5e328f93/attachment.sig>