[Bug 452059] Cannot enter slashes

[gnome-dictionary (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=452059
  gnome-dictionary | general | git master

Emmanuele Bassi (:ebassi) <ebassi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267779|none                        |reviewed
             status|                            |

--- Comment #7 from Emmanuele Bassi (:ebassi) <ebassi at gmail.com> 2014-02-02 16:39:47 UTC ---
Review of attachment 267779:
 --> (https://bugzilla.gnome.org/review?bug=452059&attachment=267779)

thanks for the patch. it looks good to me.

the commit message could be a bit better, though. the first line should be
something like:

    Drop slash for the search action

which describes what the change is about, instead of what actually changed
(what changed is visible when looking at the commit log because Git can easily
show the diff alongside the commit message).

the description should wrap at 72 or 74 columns, but the content of the text
looks okay already.

it would be great if you could rework the commit message to be in line with the
Git commit guidelines used by GNOME: https://wiki.gnome.org/Git/CommitMessages

thanks again for the patch!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.