Bug#739964: Please ship /lib/systemd/system/configure-printer at .service

[Didier Raboud]

Package: system-config-printer-udev
Version: 1.4.3-2
Severity: normal
Tags: patch

Hi dear system-config-printer maintainers,

while working on the cups systemd integration [0], it came to my
attention that the current cups init scripts uses some udevadm trigger
black magic [1] to make sure /lib/udev/udev-configure-printer is run for
coldplugged printers. While discussing how this could be implemented in
terms of systemd unit files, I noticed that system-config-printer-udev's
source was building a .service file that I think would do this step in
the right place.

The current cups init code, it will make sure udev-configure-printer is
called _after_ cups is successfully launched for all concerned printers.
As I understand it, configure-printer at .service will make sure it
actually does the same.

Therefore, please install /lib/systemd/system/configure-printer at .service
in system-config-printer-udev; this would make any wrong hack around the
cups systemd activation useless.

The obvious patch follows:

--- system-config-printer-1.4.3/debian/system-config-printer-udev.install 2013-09-16 08:29:07.000000000 +0200
+++ system-config-printer-1.4.3/debian/system-config-printer-udev.install 2014-02-24 12:54:13.000000000 +0100
@@ -1 +1,2 @@
 debian/tmp/etc/udev /lib/
+/lib/systemd/system/configure-printer at .service

Thanks in advance, cheers,

OdyX

[0] https://lists.debian.org/debian-printing/2014/02/msg00065.html
[1] http://sources.debian.net/src/cups/1.7.1-5/debian/cups-daemon.cups.init#L50

-- System Information:
Debian Release: jessie/sid
  APT prefers testing-proposed-updates
  APT policy: (500, 'testing-proposed-updates'), (500, 'proposed-updates'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CH.UTF-8, LC_CTYPE=fr_CH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages system-config-printer-udev depends on:
ii  libc6               2.18-1
ii  libcups2            1.7.1-5+systemd1
ii  libglib2.0-0        2.38.2-5
ii  libudev1            204-7
ii  libusb-1.0-0        2:1.0.17-1+b1
ii  python-cups         1.9.63-1
ii  python-cupshelpers  1.4.3-2
ii  python-dbus         1.2.0-2+b1
pn  python:any          <none>

system-config-printer-udev recommends no packages.

system-config-printer-udev suggests no packages.

-- no debconf information