Bug#741128: libglib2.0-dev: No return values in glib/gmessages.h

Nicolas Sévelin-Radiguet nicosr at free.fr
Sun Mar 9 17:45:36 UTC 2014


On 03/09/2014 12:57 AM, Colin Watson wrote:
> Control: reassign -1 libglib2.0-dev 2.38.2-5
>
> On Sat, Mar 08, 2014 at 11:30:45PM +0100, Nicolas Sévelin-Radiguet wrote:
>> I'm building packages with clang instead of gcc. Some packages depending on glib fail to build with -Wreturn-type errors.
>> See the following log excerpt:
>>
>>          g_return_if_fail(widget != NULL);
>>          ^
>> /usr/include/glib-2.0/glib/gmessages.h:345:3: note: expanded from macro 'g_return_if_fail'
>>           return; \
>>           ^
>
> This seems like the fault of the packages using GLib.  Each
> g_return_if_* macro has a g_return_val_if_* sibling, which you're
> supposed to use in non-void contexts.  Adding return values to the
> g_return_if_* macros as your patch does would lead to many packages
> attempting to return values from void functions, which would also be
> wrong.
>
Oh, I see.
Thank you for the clarification. I was indeed able to write a patch 
using g_return_vaf_if_*.

Sorry for the noise :(

Regards,
Nicolas



More information about the pkg-gnome-maintainers mailing list