Bug#729477: gnome-system-tools 3.0.0-2ubuntu2 crashed with the following message: users-admin crashed with SIGSEGV in g_slice_free1()

[Martin Pitt]

David Manuel Pires [2013-11-13 12:06 +0000]:
> gnome-system-tools 3.0.0-2ubuntu2 crashed with the following message:

Thaddäus Tintenfisch sent a patch for this in Ubuntu [1], which I
turned into a proper debdiff. Attached.

Thanks,

Martin

[1] https://code.launchpad.net/~thad-fisch/ubuntu/trusty/gnome-system-tools/fix-1185396/+merge/210009
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
diff -Nru gnome-system-tools-3.0.0/debian/changelog gnome-system-tools-3.0.0/debian/changelog
--- gnome-system-tools-3.0.0/debian/changelog	2014-02-26 11:16:56.000000000 +0100
+++ gnome-system-tools-3.0.0/debian/changelog	2014-03-12 12:15:24.000000000 +0100
@@ -1,3 +1,12 @@
+gnome-system-tools (3.0.0-3ubuntu4) trusty; urgency=medium
+
+  * Add 12_fix_exit.patch: Drop unneeded g_object_unref call to fix a
+    segmentation fault on exit after a new user has been created. Adjust
+    gst_users_tool_finalize to fix some warnings/error messages. Thanks
+    Thaddäus Tintenfisch! (LP: #1185396)
+
+ -- Martin Pitt <martin.pitt at ubuntu.com>  Wed, 12 Mar 2014 12:14:31 +0100
+
 gnome-system-tools (3.0.0-3ubuntu3) trusty; urgency=medium
 
   * debian/patches/the_admin_group_is_sudo.patch: Change no longer used 
diff -Nru gnome-system-tools-3.0.0/debian/patches/12_fix_exit.patch gnome-system-tools-3.0.0/debian/patches/12_fix_exit.patch
--- gnome-system-tools-3.0.0/debian/patches/12_fix_exit.patch	1970-01-01 01:00:00.000000000 +0100
+++ gnome-system-tools-3.0.0/debian/patches/12_fix_exit.patch	2014-03-12 12:15:02.000000000 +0100
@@ -0,0 +1,42 @@
+Description: Drop unneeded g_object_unref call to fix a segmentation fault on exit after a new user has been created. Adjust gst_users_tool_finalize to fix some warnings/error messages.
+Author: Thaddäus Tintenfisch <thad.fisch at gmail.com>
+Bug-Ubuntu: https://launchpad.net/bugs/1185396
+Bug-Debian: https://bugs.debian.org/729477
+
+=== modified file 'src/users/users-tool.c'
+--- a/src/users/users-tool.c	2011-12-16 17:08:20 +0000
++++ b/src/users/users-tool.c	2014-03-07 19:55:37 +0000
+@@ -114,17 +114,18 @@
+ {
+ 	GstUsersTool *tool = GST_USERS_TOOL (object);
+ 
++	/* Clear models to unreference OobsUsers and OobsGroups
++	 * to be sure they are finalized properly (passwords...) */
++	users_table_clear ();
++	groups_table_clear ();
++
+ 	g_object_unref (tool->users_config);
++	g_object_unref (tool->groups_config);
+ 	g_object_unref (tool->self_config);
+-	g_object_unref (tool->groups_config);
++
+ 	g_object_unref (tool->profiles);
+ 	g_object_unref (tool->settings);
+ 
+-	/* Clear models to unreference OobsUsers and OobsGroups
+-	 * to be sure they are finalized properly (passwords...) */
+-	users_table_clear ();
+-	groups_table_clear ();
+-
+ 	(* G_OBJECT_CLASS (gst_users_tool_parent_class)->finalize) (object);
+ }
+ 
+@@ -182,7 +183,6 @@
+ 		/* update privileges table too */
+ 		privileges_table_add_group (OOBS_GROUP (group));
+ 
+-		g_object_unref (group);
+ 		valid = oobs_list_iter_next (list, &iter);
+ 	}
+ 
+
diff -Nru gnome-system-tools-3.0.0/debian/patches/series gnome-system-tools-3.0.0/debian/patches/series
--- gnome-system-tools-3.0.0/debian/patches/series	2014-02-26 11:15:38.000000000 +0100
+++ gnome-system-tools-3.0.0/debian/patches/series	2014-03-12 12:14:27.000000000 +0100
@@ -1,6 +1,7 @@
 01_wait_for_backends.patch
 10_disable_interfaces.patch
 11_dont_show_shares.patch
+12_fix_exit.patch
 25_sambashare_group_definition.patch
 26_user_profiles_conf.patch
 61_outdated_docs.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20140312/c2a204be/attachment.sig>