Bug#596054: Unaligned accesses in metatree code

[Michael Cree]

On Tue, Mar 11, 2014 at 07:20:34PM +0000, althaser wrote:
> Do you still have the unaligned ?
> 
> If so, I will forward this patch to upstream.

Gosh, I had completely forgotten about this bug.  But I have been able to
tickle gvfs into generating an unaligned access.  From the kernel log

[ 1651.617187] gvfsd-metadata(12340): unaligned trap at 0000000120009718: 000002000095201c 29 12

And running gvfsd-metadata under gdb:

(gdb) list *0x0000000120009718
0x120009718 is in meta_tree_flush_locked (metatree.c:2227).
2222	  journal = tree->journal;
2223	
2224	  entry = journal->first_entry;
2225	  while (entry < journal->last_entry)
2226	    {
2227	      mtime = GUINT64_FROM_BE (entry->mtime);
2228	      journal_path = &entry->path[0];
2229	
2230	      switch (entry->entry_type)
2231		{


which is the very code my patch touches.  So, yes, the unaligned access is
still there.

Cheers
Michael.