Bug#730756: libimobiledevice crash, fails to get buid from usbmuxd...

[Andreas Henriksson]

Hello Josep!

On Fri, May 02, 2014 at 12:03:35PM +0200, Josep M. Perez Cancer wrote:
> Hi,
> 
> Apparently usbmuxd is not expecting the "ReadBUID" command:
> 
> [11:56:02.254][4] New client on fd 14
> [11:56:18.430][5] Client command in fd 14 len 501 ver 1 msg 8 tag 10
> [11:56:18.430][1] Unexpected command 'ReadBUID' received!
> [11:56:18.430][5] send_pkt fd 14 tag 10 msg 8 payload_length 278
[...]

Thanks for the info!

> 
> On 30/04/14 18:53, Andreas Henriksson wrote:
> >Hello!
> >
> >Thanks for the backtrace you provided in your bug report!
> >
> >It looks to me like the problem is in this snippet from libimobiledevice
> >src/lockdown.c :
> >
> >         /* set SystemBUID */
> >         userpref_read_system_buid(&system_buid);
> >         plist_dict_set_item(*pair_record, USERPREF_SYSTEM_BUID_KEY, plist_new_string(system_buid));
[...]

Do you think you could rebuild libimobiledevice with the above code
changed to:

	if (userpref_read_system_build(&system_buid)) {
		plist_dict_set_item(*pair_record, USERPREF_SYSTEM_BUID_KEY, plist_new_string(system_buid));
	}

... and report back what happens?

(Sorry for not providing a proper patch, but I have very limited connection
right now.)

Would also be nice to have some information on which model of the
device you are using for testing!

The crash seems to have been introduced in:
https://github.com/libimobiledevice/libimobiledevice/commit/1331f6baa1799e41003aa812c0d1bf36193535ea

Regards,
Andreas Henriksson