Bug#749001: Conflicting return types of functions seahorse_dbus_server_{init, cleanup}

[Michael Tautschnig]

Package: libcryptui
Version: 3.8.0-1
Severity: wishlist
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
libtool: link: gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -Wl,-z -Wl,relro -Wl,-z -Wl,defs -Wl,-O1 -o seahorse-daemon seahorse-daemon.o seahorse-dbus-server.o seahorse-gpgme.o seahorse-gpgme-data.o seahorse-gpgme-generate.o seahorse-gpgme-key.o seahorse-gpgme-key-op.o seahorse-gpgme-operation.o seahorse-gpgme-source.o seahorse-gpgme-subkey.o seahorse-gpgme-uid.o seahorse-gpg-op.o seahorse-gpg-options.o seahorse-object-list.o seahorse-pgp.o seahorse-pgp-key.o seahorse-pgp-module.o seahorse-pgp-signature.o seahorse-pgp-subkey.o seahorse-pgp-uid.o seahorse-secure-buffer.o seahorse-service.o seahorse-service-keyset.o seahorse-service-crypto.o seahorse-context.o seahorse-gtkstock.o seahorse-notification.o seahorse-object.o seahorse-operation.o seahorse-passphrase.o seahorse-progress.o seahorse-secure-memory.o seahorse-set.o seahorse-source.o seahorse-transfer-operation.o seahorse-types.o seahorse-unix-signal.o seahorse-unknown.o seahorse-unknown-source.o seahorse-util.o seahorse-validity.o seahorse-widget.o seahorse-marshal.o -Wl,--export-dynamic -pthread -pthread  -Wl,--as-needed ../libcryptui/.libs/libcryptui-private.a ../libegg/.libs/libeggdatetime.a ../libegg/.libs/libeggsmclient.a -lSM -lICE -lgmodule-2.0 -lgthread-2.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 /usr/lib/x86_64-linux-gnu/libcairo-gobject.so /usr/lib/x86_64-linux-gnu/libcairo.so -L/usr/lib/x86_64-linux-gnu -lgpgme -lassuan -lgpg-error -ldbus-glib-1 -ldbus-1 -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lgnome-keyring -lglib-2.0 -pthread

error: conflicting function declarations "seahorse_dbus_server_init"
old definition in module seahorse-daemon file seahorse-daemon.h line 30
signed int ()
new definition in module seahorse-dbus-server file seahorse-dbus-server.c line 48
void ()
Makefile:637: recipe for target 'seahorse-daemon' failed
make[4]: *** [seahorse-daemon] Error 64
make[4]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-libcryptui/libcryptui-3.8.0/daemon'
Makefile:551: recipe for target 'all' failed
make[3]: *** [all] Error 2

Indeed the same type conflict applies for seahorse_dbus_server_cleanup - neither
of them actually provide a return value:

http://sources.debian.net/src/libcryptui/3.8.0-1/daemon/seahorse-dbus-server.c?hl=47,48,118,119#L47

Yet the declaration here claims so, which may lead to future inadvertent use of
that return value:

http://sources.debian.net/src/libcryptui/3.8.0-1/daemon/seahorse-daemon.h?hl=30,32#L30

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20140522/3e1e9993/attachment.sig>