Bug#761824: gnome-system-tools: src/common/gst-tool.c - update_async_func ignores liboobs' errors

[Vlad Orlov]

Source: gnome-system-tools
Version: 3.0.0-3
Severity: important

Hi,

gnome-system-tools has a severe flaw: one of its common functions,
update_async_func (a callback which is in src/common/gst-tool.c)
ignores OobsResult that's passed to it.

This leads to some errors being hidden from the user in the cases
when some data can't be retrieved from liboobs, e.g. [1] (see the
first "Liboobs-WARNING" there).

I'd easily add a result check there, but I'm not sure about 2 things:

1) maybe the absence of the check is intentional for some reason?
2) if not, should the application exit immediately on error, like
it's done in gst_tool_constructor function (in the same file)?


[1] https://bugs.debian.org/761806