Bug#797132: gobject-introspection: missing -fPIC option when compiling

[Samuel Thibault]

Package: gobject-introspection
Version: 1.44.0-1+b2
Severity: serious
Justification: makes other package FTBFS

Hello,

at-spi2-core currently FTBFS in sid, because of g-ir-scanner's way of
compiling, here is what the log looks like:

/usr/bin/g-ir-scanner  --add-include-path=. --warn-all --c-include='atspi/atspi.h' --namespace=Atspi --nsversion=2.0 --libtool="/bin/bash ../libtool" --pkg=dbus-1 --include=GLib-2.0 --include=GObject-2.0 --pkg-export=atspi-2  --library=libatspi.la --library=../dbind/libdbind.la --namespace Atspi --nsversion=2.0 --cflags-begin -I.. -I.. --cflags-end  atspi-enum-types.c atspi-enum-types.h atspi.h atspi-accessible.h atspi-action.h atspi-application.h atspi-collection.h atspi-component.h atspi-constants.h atspi-device-listener.h atspi-device-listener-private.h atspi-document.h atspi-editabletext.h atspi-event-listener.h atspi-event-listener-private.h atspi-gmain.c atspi-gmain.h atspi-hyperlink.h atspi-hypertext.h atspi-image.h atspi-matchrule.h atspi-misc.h atspi-object.h atspi-private.h atspi-registry.h atspi-relation.h atspi-selection.h atspi-stateset.h atspi-table.h atspi-table-cell.h atspi-text.h atspi-types.h atspi-value.h atspi-accessible.c atspi-accessible-private.h atspi-action.c atspi-application.c atspi-collection.c atspi-component.c atspi-device-listener.c atspi-document.c atspi-editabletext.c atspi-event-listener.c atspi-hyperlink.c atspi-hypertext.c atspi-image.c atspi-matchrule.c atspi-matchrule-private.h atspi-misc.c atspi-misc-private.h atspi-object.c atspi-registry.c atspi-relation.c atspi-selection.c atspi-stateset.c atspi-table.c atspi-table-cell.c atspi-text.c atspi-value.c libatspi.la --output Atspi-2.0.gir
atspi-gmain.c:44: Error: Atspi: Skipping invalid GTK-Doc comment block:
/**< the parent GSource */
^
atspi-gmain.c:45: Error: Atspi: Skipping invalid GTK-Doc comment block:
/**< the connection to dispatch */
^
atspi-gmain.c:98: Error: Atspi: Skipping invalid GTK-Doc comment block:
/**< the main context */
^
atspi-gmain.c:99: Error: Atspi: Skipping invalid GTK-Doc comment block:
/**< all IOHandler */
^
atspi-gmain.c:100: Error: Atspi: Skipping invalid GTK-Doc comment block:
/**< all TimeoutHandler */
^
atspi-gmain.c:101: Error: Atspi: Skipping invalid GTK-Doc comment block:
/**< NULL if this is really for a server not a connection */
^
atspi-gmain.c:102: Error: Atspi: Skipping invalid GTK-Doc comment block:
/**< DBusGMessageQueue */
^
atspi-gmain.c:513: Error: Atspi: Skipping invalid GTK-Doc comment block:
/** @} */
^
g-ir-scanner: compile: cc -Wno-deprecated-declarations -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -D_FORTIFY_SOURCE=2 -Wall -g -Werror-implicit-function-declaration -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -c -o /tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0.o /tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0.c
g-ir-scanner: link: /bin/bash ../libtool --mode=link --tag=CC cc -o /tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0 -export-dynamic -D_FORTIFY_SOURCE=2 -Wall -g -Werror-implicit-function-declaration -fPIE -pie -Wl,-z,relro -Wl,-z,now /tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0.o -L. libatspi.la ../dbind/libdbind.la -lgio-2.0 -lgobject-2.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lglib-2.0 -ldbus-1
libtool: link: cc -o /tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/.libs/Atspi-2.0 -D_FORTIFY_SOURCE=2 -Wall -g -Werror-implicit-function-declaration -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now /tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0.o -Wl,--export-dynamic -pthread -Wl,--export-dynamic  -L. ./.libs/libatspi.so ../dbind/.libs/libdbind.a -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -ldbus-1 -pthread
/usr/bin/ld: /tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
/tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0.o: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
linking of temporary binary failed: Command '['/bin/bash', '../libtool', '--mode=link', '--tag=CC', 'cc', '-o', '/tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0', '-export-dynamic', '-D_FORTIFY_SOURCE=2', '-Wall', '-g', '-Werror-implicit-function-declaration', '-fPIE', '-pie', '-Wl,-z,relro', '-Wl,-z,now', '/tmp/buildd/at-spi2-core-2.16.0/atspi/tmp-introspect9yGBBn/Atspi-2.0.o', '-L.', 'libatspi.la', '../dbind/libdbind.la', '-lgio-2.0', '-lgobject-2.0', '-Wl,--export-dynamic', '-lgmodule-2.0', '-pthread', '-lglib-2.0', '-ldbus-1']' returned non-zero exit status 1
/usr/share/gobject-introspection-1.0/Makefile.introspection:153: recipe for target 'Atspi-2.0.gir' failed

Atspi-2.0.o was indeed not built with -fPIC.  I don't know how all this
is supposed to use -fPIC/-fPIE.

Samuel

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gobject-introspection depends on:
ii  build-essential        11.7
ii  libc6                  2.19-19
ii  libffi6                3.2.1-3
ii  libgirepository-1.0-1  1.44.0-1+b2
ii  libglib2.0-0           2.44.1-1.1
ii  python-mako            1.0.0+dfsg-0.1
pn  python:any             <none>

gobject-introspection recommends no packages.

gobject-introspection suggests no packages.

-- no debconf information

-- 
Samuel
       void *memmem (const void *meule_de_foin, size_t lg_meule,
              const void *aiguille, size_t lg_aiguille);
(extrait de la page de man de memmem -- Manuel du programmeur Linux)