Bug#802326: segfault in g_time_zone_get_abbreviation()

[Sebastien Bacher]

Package: gnome-system-log
Version: 3.9.90-3
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu wily ubuntu-patch

The current version has a free before use issue, that's resolved in git
but upstream is unactive and there has been not tarball since
https://git.gnome.org/browse/gnome-system-log/commit/?id=a09f87bafc833d199cfd8364dff72b4c2e812af8

(the issue leads to invalid dates displayed and segfault, see
https://bugs.launchpad.net/ubuntu/+source/gnome-system-log/+bug/1500806
and https://bugzilla.gnome.org/show_bug.cgi?id=697802)
-------------- next part --------------
diff -Nru gnome-system-log-3.9.90/debian/changelog gnome-system-log-3.9.90/debian/changelog
--- gnome-system-log-3.9.90/debian/changelog	2015-05-24 18:20:13.000000000 +0200
+++ gnome-system-log-3.9.90/debian/changelog	2015-10-19 16:11:35.000000000 +0200
@@ -1,3 +1,10 @@
+gnome-system-log (3.9.90-4) wily; urgency=medium
+
+  * debian/patches/03_git_invalid_unref.patch:
+    - backport upstream commit to fix segfaults (lp: #1500806)
+
+ -- Sebastien Bacher <seb128 at ubuntu.com>  Mon, 19 Oct 2015 16:10:52 +0200
+
 gnome-system-log (3.9.90-3) unstable; urgency=medium
 
   [ Andreas Henriksson ]
diff -Nru gnome-system-log-3.9.90/debian/patches/03_git_invalid_unref.patch gnome-system-log-3.9.90/debian/patches/03_git_invalid_unref.patch
--- gnome-system-log-3.9.90/debian/patches/03_git_invalid_unref.patch	1970-01-01 01:00:00.000000000 +0100
+++ gnome-system-log-3.9.90/debian/patches/03_git_invalid_unref.patch	2015-10-19 16:10:27.000000000 +0200
@@ -0,0 +1,33 @@
+From a09f87bafc833d199cfd8364dff72b4c2e812af8 Mon Sep 17 00:00:00 2001
+From: Daniel Wyatt <Daniel.Wyatt at gmail.com>
+Date: Mon, 23 Dec 2013 17:35:49 -0500
+Subject: Fix incorrect last updated times by not unrefing log_time too early
+
+---
+ src/logview-window.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/logview-window.c b/src/logview-window.c
+index 3d7a768..7639e01 100644
+--- a/src/logview-window.c
++++ b/src/logview-window.c
+@@ -191,7 +191,6 @@ logview_update_header (LogviewWindow *logview,
+   log_time = g_date_time_new_from_unix_local (timestamp);
+ 
+   text = logview_utils_format_date (log_time);
+-  g_date_time_unref (log_time);
+ 
+   /* translators: this is part of a label composed with
+    * a date string, for example "updated today 23:54"
+@@ -202,6 +201,7 @@ logview_update_header (LogviewWindow *logview,
+   g_free (text);
+ 
+   text = g_date_time_format (log_time, "%X");
++  g_date_time_unref (log_time);
+   g_string_append (string, " ");
+   g_string_append (string, text);
+   g_free (text);
+-- 
+cgit v0.11.2
+
+
diff -Nru gnome-system-log-3.9.90/debian/patches/series gnome-system-log-3.9.90/debian/patches/series
--- gnome-system-log-3.9.90/debian/patches/series	2014-09-23 17:51:24.000000000 +0200
+++ gnome-system-log-3.9.90/debian/patches/series	2015-10-19 16:10:41.000000000 +0200
@@ -1,2 +1,3 @@
 01_logview_pkexec.patch
 02_no_timestamp_styling.patch
+03_git_invalid_unref.patch