Bug#597020: libgksu: sudo mode: no second attempt and no feedback when wrong password entered

David Kohen david at panda-os.com
Mon Sep 7 11:33:04 UTC 2015


In the Ubuntu package there is an additional patch that fixes this issue,
patch following signature.
It applies and fixes the issue on the current version of jessie
(2.0.13~pre1-8)
-- 
*David Kohen - Software Engineer.*
www.panda-os.com
[image: www.panda-os.com] <http://www.panda-os.com>


## Description: Checks if buffer contains only newline before discarding it
## Origin/Author: Torsten Spindler (Canonical)
## Bug: http://pad.lv/298217
diff -Nur -x '*.orig' -x '*~' libgksu-2.0.13~pre1//libgksu/libgksu.c
libgksu-2.0.13~pre1.new//libgksu/libgksu.c
--- libgksu-2.0.13~pre1//libgksu/libgksu.c 2011-09-13 09:43:51.723178003
+0200
+++ libgksu-2.0.13~pre1.new//libgksu/libgksu.c 2011-09-13
09:46:16.603182354 +0200
@@ -2980,16 +2980,22 @@
   /* ignore the first newline that comes right after sudo receives
      the password */
   fgets (buffer, 255, fdfile);
-  /* this is the status we are interested in */
-  fgets (buffer, 255, fdfile);
+          if (!strcmp (buffer, "\n"))
+            {
+      /* this is the status we are interested in */
+      fgets (buffer, 255, fdfile);
+            }
 #else
           fcntl(parent_pipe[0], F_SETFL, fcntl(parent_pipe[0], F_GETFL) &
~O_NONBLOCK);

   /* ignore the first newline that comes right after sudo receives
      the password */
   fgets (buffer, 255, infile);
-  /* this is the status we are interested in */
-  fgets (buffer, 255, infile);
+          if (!strcmp (buffer, "\n"))
+            {
+      /* this is the status we are interested in */
+      fgets (buffer, 255, infile);
+            }
 #endif
  }
       else
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20150907/82d3d7f1/attachment-0001.html>


More information about the pkg-gnome-maintainers mailing list