Bug#819886: gtk-doc-tools: /usr/bin/gtkdoc-mkpdf always exits with an error

[Andreas Metzler]

Package: gtk-doc-tools
Version: 1.25-1
Severity: serious
Tags: patch

Quoting gtkdoc-mkpdf.in (and /usr/bin/gtkdoc-mkpdf):
--------------------------
cleanexit() {
    rm -f $module.fo
    exit 1
}
[...]
      echo "dblatex or fop must be installed to use gtkdoc-mkpdf." >&2
      cleanexit 1
    fi
  fi
else
    # not very good output
    # also for xxx-docs.sgml it will produce xxx-docs.pdf
    docbook2pdf -e no-valid "$document"
fi

echo "timestamp" > pdf.stamp
cleanexit 0
--------------------------

So cleanexit() is supposed to take an exitcode as argument but ignores it and exits with 1 instead. Obviously the function definition should read
cleanexit() {
    rm -f $module.fo
    exit $1
}

Whis is exactly how the code looked like in 1.24-2.

cu Andreas