Bug#822473: gnome-software: FTBFS: static declaration of 'as_app_has_compulsory_for_desktop' follows non-static declaration

[Martin Michlmayr]

Package: gnome-software
Version: 3.18.3-3
Severity: serious

This package fails to build in unstable:

> sbuild (Debian sbuild) 0.68.0 (15 Jan 2016) on dl580gen9-02.hlinux
...
> -pthread -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/fwupd-1 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/Limba -DBINDIR=\"/usr/bin\" -DDATADIR=\"/usr/share\" -DGS_MODULESETDIR=\"/usr/share/gnome-software/modulesets.d\" -DG_LOG_DOMAIN=\"GsPlugin\" -DLIBDIR=\"/usr/lib\" -DLOCALSTATEDIR=\"/var\" -DSBINDIR=\"/usr/sbin\" -DSYSCONFDIR=\"/etc\" -DTESTDATADIR=\"../../data/tests\" -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wstrict-prototypes -Wnested-externs -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werror=format-security -Werror=format=2 -Werror=missing-include-dirs -Werror=return-type -Wmissing-declarations -Wcast-align -Wwrite-strings -Wreturn-type -Wformat-nonliteral -Wmissing-format-attribute -Wclobbered -Wempty-body -Wignored-qualifiers -Wsign-compare -Wtype-limits -Wuninitialized -Waggregate-return -Wdeclaration-after-statement -Wshadow -Wno-strict-aliasing -Winline -Wmissing-parameter-type -Woverride-init -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c gs-plugin-appstream.c  -fPIC -DPIC -o .libs/libgs_plugin_appstream_la-gs-plugin-appstream.o
> In file included from ../../src/gs-plugin.h:30:0,
>                  from gs-plugin-appstream.c:27:
> ../../src/gs-app.h:109:1: warning: 'AsIdKind' is deprecated: Use AsAppKind instead [-Wdeprecated-declarations]
>  AsIdKind  gs_app_get_id_kind  (GsApp  *app);
>  ^
> In file included from /usr/include/libappstream-glib/as-app.h:32:0,
>                  from /usr/include/libappstream-glib/appstream-glib.h:27,
>                  from gs-plugin-appstream.c:25:
> /usr/include/libappstream-glib/as-enums.h:49:14: note: declared here
>  typedef enum {
>               ^
> In file included from ../../src/gs-plugin.h:30:0,
>                  from gs-plugin-appstream.c:27:
> ../../src/gs-app.h:111:8: warning: 'AsIdKind' is deprecated: Use AsAppKind instead [-Wdeprecated-declarations]
>         AsIdKind  id_kind);
>         ^
> In file included from /usr/include/libappstream-glib/as-app.h:32:0,
>                  from /usr/include/libappstream-glib/appstream-glib.h:27,
>                  from gs-plugin-appstream.c:25:
> /usr/include/libappstream-glib/as-enums.h:49:14: note: declared here
>  typedef enum {
>               ^
> gs-plugin-appstream.c:54:1: error: static declaration of 'as_app_has_compulsory_for_desktop' follows non-static declaration
>  as_app_has_compulsory_for_desktop (AsApp *app, const gchar *compulsory_for_desktop)
>  ^
> In file included from /usr/include/libappstream-glib/appstream-glib.h:27:0,
>                  from gs-plugin-appstream.c:25:
> /usr/include/libappstream-glib/as-app.h:340:11: note: previous declaration of 'as_app_has_compulsory_for_desktop' was here
>  gboolean  as_app_has_compulsory_for_desktop (AsApp *app,
>            ^
> gs-plugin-appstream.c: In function 'gs_plugin_refine_item':
> gs-plugin-appstream.c:473:3: warning: 'as_app_get_id_kind' is deprecated: Use 'as_app_get_kind' instead [-Wdeprecated-declarations]
>    if (as_app_get_id_kind (item) == AS_ID_KIND_SOURCE) {
>    ^
> In file included from /usr/include/libappstream-glib/appstream-glib.h:27:0,
>                  from gs-plugin-appstream.c:25:
> /usr/include/libappstream-glib/as-app.h:480:11: note: declared here
>  AsIdKind  as_app_get_id_kind  (AsApp  *app)
>            ^
> gs-plugin-appstream.c:598:3: warning: 'as_app_get_id_kind' is deprecated: Use 'as_app_get_kind' instead [-Wdeprecated-declarations]
>    gs_app_set_id_kind (app, as_app_get_id_kind (item));
>    ^
> In file included from /usr/include/libappstream-glib/appstream-glib.h:27:0,
>                  from gs-plugin-appstream.c:25:
> /usr/include/libappstream-glib/as-app.h:480:11: note: declared here
>  AsIdKind  as_app_get_id_kind  (AsApp  *app)
>            ^
> Makefile:1013: recipe for target 'libgs_plugin_appstream_la-gs-plugin-appstream.lo' failed
> make[5]: *** [libgs_plugin_appstream_la-gs-plugin-appstream.lo] Error 1
> make[5]: Leaving directory '/<<PKGBUILDDIR>>/src/plugins'
> Makefile:2087: recipe for target 'all-recursive' failed

-- 
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise