Bug#834457: libgtk-3-0: inconsistent signed/unsigned length parameter in gtk_builder_new_from_string() and gtk_builder_add_from_string()

[Joe Pfeiffer]

Package: libgtk-3-0
Version: 3.21.4-1
Severity: minor

gssize is signed, gsize is not.

gtk_builder_new_from_string() has the prototype

GtkBuilder *
gtk_builder_new_from_string (const gchar *string,
                             gssize       length)

It passes length to gtk_builder_add_from_string(), which has the
prototype

guint
gtk_builder_add_from_string (GtkBuilder   *builder,
                             const gchar  *buffer,
                             gsize         length,
                             GError      **error)

This in turn passes length to _gtk_builder_parser_parse_buffer(), with
prototype

void
_gtk_builder_parser_parse_buffer (GtkBuilder   *builder,
                                  const gchar  *filename,
                                  const gchar  *buffer,
                                  gsize         length,
                                  gchar       **requested_objs,
                                  GError      **error)

This passes length to g_markup_parse_context_parse(), with prototype

gboolean
g_markup_parse_context_parse (GMarkupParseContext  *context,
                              const gchar          *text,
                              gssize                text_len,
                              GError              **error)


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (700, 'testing'), (650, 'stable'), (600, 'unstable'), (550, 'experimental'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libgtk-3-0 depends on:
ii  libatk-bridge2.0-0                      2.20.1-3
ii  libatk1.0-0                             2.20.0-1
ii  libc6                                   2.23-4
ii  libcairo-gobject2                       1.14.6-1+b1
ii  libcairo2                               1.14.6-1+b1
ii  libcolord2                              1.3.2-1
ii  libcups2                                2.1.4-4
ii  libepoxy0                               1.3.1-1
ii  libfontconfig1                          2.11.0-6.5
ii  libfreetype6                            2.6.3-3+b1
ii  libgdk-pixbuf2.0-0                      2.34.0-1
ii  libglib2.0-0                            2.49.4-1
ii  libgtk-3-common                         3.21.4-1
ii  libjson-glib-1.0-0                      1.2.2-1
ii  libpango-1.0-0                          1.40.1-1
ii  libpangocairo-1.0-0                     1.40.1-1
ii  libpangoft2-1.0-0                       1.40.1-1
ii  librest-0.7-0                           0.8.0-1
ii  libsoup2.4-1                            2.54.1-1
ii  libwayland-client0                      1.11.0-2
ii  libwayland-cursor0                      1.11.0-2
ii  libwayland-egl1-mesa [libwayland-egl1]  11.2.2-1
ii  libx11-6                                2:1.6.3-1
ii  libxcomposite1                          1:0.4.4-1
ii  libxcursor1                             1:1.1.14-1+b1
ii  libxdamage1                             1:1.1.4-2+b1
ii  libxext6                                2:1.3.3-1
ii  libxfixes3                              1:5.0.2-1
ii  libxi6                                  2:1.7.6-1
ii  libxinerama1                            2:1.1.3-1+b1
ii  libxkbcommon0                           0.5.0-1
ii  libxml2                                 2.9.4+dfsg1-1+b1
ii  libxrandr2                              2:1.5.0-1
ii  shared-mime-info                        1.6-1

Versions of packages libgtk-3-0 recommends:
ii  libgtk-3-bin  3.20.7-1

Versions of packages libgtk-3-0 suggests:
ii  gvfs             1.28.2-1
ii  librsvg2-common  2.40.16-1

-- no debconf information