Bug#834230: libgtk-3-0: FTBFS on current sid

[Norbert Preining]

Hi Simon,

thanks for coming back to me ..

> * something non-obvious was fixed between 3.20.7 and 3.20.9 and I couldn't
>   see it (I'm trying 3.20.7 now, but it will take a while);

Obviously this was not the case as you tested it.

> * something outside Gtk changed between then and now, fixing this test;

Hmm, what could that be?

> * something is different on your system (maybe a non-standard theme?)
>   that is somehow affecting the build;

I am running cinnamon with some dark theme, could this be the problem?

> * the test is non-reproducible

I can reproduce the failure and did it several times before sending
the bug report using the make invocation.

> 3.20.7 also works fine for me, leaving these possibilities:

Hmm, I will try in a clean cowbuilder/pbuilder and see if that changes
something.

BTW, I would like to see fixes to the flashing widgets (see various
nemo and other bugs). Upstream included git ddcf4702 and it would
be nice to see something like this backported into current Debian.

Thanks

Norbert

--
PREINING Norbert + TeX Live & Debian Developer + http://www.preining.info
GPG: 0x860CDC13    fp: F7D8 A928 26E3 16A1 9FA0  ACF0 6CAC A448 860C DC13
-------------- next part --------------
---
 gtk/gtkwidget.c        |   13 +------------
 gtk/gtkwidgetprivate.h |    1 -
 2 files changed, 1 insertion(+), 13 deletions(-)

--- gtk+3.0-3.20.7.orig/gtk/gtkwidget.c
+++ gtk+3.0-3.20.7/gtk/gtkwidget.c
@@ -5473,9 +5473,6 @@
       gtk_widget_ensure_style (widget);
       G_GNUC_END_IGNORE_DEPRECATIONS;
 
-      if (priv->style_update_pending)
-        g_signal_emit (widget, widget_signals[STYLE_UPDATED], 0);
-
       g_signal_emit (widget, widget_signals[REALIZE], 0);
 
       gtk_widget_real_set_has_tooltip (widget,
@@ -16546,15 +16543,7 @@
 void
 _gtk_widget_style_context_invalidated (GtkWidget *widget)
 {
-  if (_gtk_widget_get_realized (widget))
-    g_signal_emit (widget, widget_signals[STYLE_UPDATED], 0);
-  else
-    {
-      /* Compress all style updates so it
-       * is only emitted once pre-realize.
-       */
-      widget->priv->style_update_pending = TRUE;
-    }
+  g_signal_emit (widget, widget_signals[STYLE_UPDATED], 0);
 }
 
 GtkCssNode *
--- gtk+3.0-3.20.7.orig/gtk/gtkwidgetprivate.h
+++ gtk+3.0-3.20.7/gtk/gtkwidgetprivate.h
@@ -66,7 +66,6 @@
   guint receives_default      : 1;
   guint has_grab              : 1;
   guint shadowed              : 1;
-  guint style_update_pending  : 1;
   guint app_paintable         : 1;
   guint double_buffered       : 1;
   guint redraw_on_alloc       : 1;