Bug#835886: gnome-photos: please use dbus-run-session to run tests

[Simon McVittie]

On Mon, 29 Aug 2016 at 04:15:30 +0200, Michael Biebl wrote:
> Am 29.08.2016 um 02:50 schrieb Simon McVittie:
> > Source: gnome-photos
> > Version: 3.20.3-1

> > It should be possible to replace dbus-x11 as follows:
> > 
> > * replace the test dependency on dbus-x11 with dbus (>= 1.8)
> > * replace "xvfb-run -a make -C tests check" with
> >   "dbus-run-session -- xvfb-run -a make -C tests check"
> 
> Is this a false positive / the wrong package?
> 
> I don't see a dbus-x11 dependency nor the use of dbus-launch in
> gnome-photos_3.20.3-1

No, I think this is a valid bug report:

    % apt-get source gnome-photos/unstable
    ...
    % ack '(dbus-(launch|x11))' debian/tests/control
    2:Depends: @, @builddeps@, dbus-x11, xvfb, grilo-plugins-0.3, xauth
    % cat debian/tests/unit-tests
    #!/bin/sh
    
    xvfb-run -a make -C tests check

This looks as though it's relying on the xvfb session autolaunching
a session dbus-daemon for its DISPLAY, which requires dbus-x11.

    S