Bug#836086: deja-dup: please use dbus-run-session, and/or dbus-daemon directly, in tests

[Simon McVittie]

Source: deja-dup
Version: 34.2-1
Severity: minor
Tags: upstream
User: dbus at packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-launch in its unit tests, in ways that
will typically leak multiple dbus-daemon processes per test run.

The tests do not appear to be run in Debian, only by upstream, but this is
one of up to 300 bugs on this topic being filed this week so I'm not able
to go looking for all the upstream bug trackers.

For test.sh, this Flatpak commit illustrates how `eval dbus-launch`
can be replaced by invoking dbus-daemon directly, avoiding the
X11-specific dbus-launch:
<https://github.com/flatpak/flatpak/commit/6cc8062cfb3f9410d54a27e7ccca77c103e441e8>.
This does not require dbus-x11, only dbus.

For tests/shell, libdeja/tests/CMakeLists.txt and
libdeja/tests/unit/CMakeLists.txt, commands like "dbus-launch ./test-runner"
should be replaced by "dbus-run-session -- ./test-runner". This requires
at least dbus 1.8, which was first released in early 2014 and is currently
the oldest branch with upstream security support, so it should be a
non-problematic dependency.

Thanks,
    S