Bug#841098: not fixed in rygel 0.32.1-1

Andreas Henriksson andreas at fatal.se
Sun Nov 13 19:54:44 UTC 2016


Control: tags -1 - patch

Hello Santiago Vila.

Thanks for trying to contribute, but you're patch is fundamentally
flawed.

On Fri, Oct 21, 2016 at 02:07:28PM +0200, Santiago Vila wrote:
> tags 841098 + patch
> thanks
> 
> Here is a patch. After applying it the package builds fine and without failures.
>

If you really think that a test-suite detecting an issue should
be solved not by fixing the issue (or fixing a potential flakyness
in the test) but rather by disabling the test you should
be sending a patch against debhelper to remove dh_auto_test
from the sequiencer in dh.

Also when you're patching upstream sources I'd appreciate if
you send your patches via upstream QA (and ask me to cherry-pick
them if urgent once they've been applied in upstream git).

Regards,
Andreas Henriksson

 



More information about the pkg-gnome-maintainers mailing list