Bug#850836: gnome-screenshot: Generated generic filenames use colon in timestamp which is bad for some filesystems

[Moritz Schlarb]

Control: tags -1 + patch pending fixed-upstream

Hi Andreas,

thank you for your reply!

On 12.01.2017 17:52, Andreas Henriksson wrote:
> Same thing applies here to gnome-screenshot as was already said for
> the equivalent gnome-settings-daemon bug report in #850837
> 
> (This mail mainly to add more meta-data to the bug report for tracking
> purposes.)

I have created a patch from a combination of the patch from upstream bug
#698740 and upstream commit aa23783 to achieve the behaviour intended by
successive upstream releases.
The rationale behind this to not just import the bug from the upstream
bug report is to not disrupt user experience once now in Jessie and then
another time when Stretch is released but just once now.

I added the patch to debian/patches, updated the changelog, built the
package, tested it and attached the debdiff here (and FWIW uploaded it
to https://mentors.debian.net/package/gnome-screenshot).

I will now contact the Debian Stable Release Managers.

Best wishes,
-- 
Moritz Schlarb
Unix-Gruppe | Systembetreuung
Zentrum für Datenverarbeitung
Johannes Gutenberg-Universität Mainz
Raum 01-321 - Tel. +49 6131 39-29441
OpenPGP Fingerprint: DF01 2247 BFC6
5501 AFF2 8445 0C24 B841 C7DD BAAF
-------------- next part --------------
diff -Nru gnome-screenshot-3.14.0/debian/changelog gnome-screenshot-3.14.0/debian/changelog
--- gnome-screenshot-3.14.0/debian/changelog	2014-09-23 15:43:32.000000000 +0200
+++ gnome-screenshot-3.14.0/debian/changelog	2017-02-08 11:00:32.000000000 +0100
@@ -1,3 +1,14 @@
+gnome-screenshot (3.14.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * filename-builder-use-dash-for-time-format-separator.patch:
+    Combination of the patch from upstream bug #698740 and upstream
+    commit aa23783 to achieve the behaviour intended by successive
+    upstream releases.
+    (Closes: #850836)
+
+ -- Moritz Schlarb <schlarbm at uni-mainz.de>  Wed, 08 Feb 2017 10:28:37 +0100
+
 gnome-screenshot (3.14.0-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru gnome-screenshot-3.14.0/debian/patches/filename-builder-use-dash-for-time-format-separator.patch gnome-screenshot-3.14.0/debian/patches/filename-builder-use-dash-for-time-format-separator.patch
--- gnome-screenshot-3.14.0/debian/patches/filename-builder-use-dash-for-time-format-separator.patch	1970-01-01 01:00:00.000000000 +0100
+++ gnome-screenshot-3.14.0/debian/patches/filename-builder-use-dash-for-time-format-separator.patch	2017-02-08 10:53:06.000000000 +0100
@@ -0,0 +1,20 @@
+Subject: filename-builder: use dash for time format separator
+
+This patch is a combination of the patch from upstream bug #698740
+and upstream commit aa23783 to achieve the behaviour intended by
+successive upstream releases.
+
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=698740
+Origin: https://github.com/GNOME/gnome-screenshot/commit/aa23783c39f96dd0b45f70d82557736a5b884c55
+
+--- a/src/screenshot-filename-builder.c
++++ b/src/screenshot-filename-builder.c
+@@ -131,7 +131,7 @@ build_path (AsyncExistenceJob *job)
+       GDateTime *d;
+ 
+       d = g_date_time_new_now_local ();
+-      origin = g_date_time_format (d, "%Y-%m-%d %H:%M:%S");
++      origin = g_date_time_format (d, "%Y-%m-%d %H-%M-%S");
+       g_date_time_unref (d);
+     }
+   else
diff -Nru gnome-screenshot-3.14.0/debian/patches/series gnome-screenshot-3.14.0/debian/patches/series
--- gnome-screenshot-3.14.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ gnome-screenshot-3.14.0/debian/patches/series	2017-02-08 10:40:56.000000000 +0100
@@ -0,0 +1 @@
+filename-builder-use-dash-for-time-format-separator.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: schlarbm.vcf
Type: text/x-vcard
Size: 367 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20170208/80bbccee/attachment.vcf>