Bug#850837: gnome-settings-daemon: screenshot-utils filenames use colon in timestamp which is bad for some fs

[Moritz Schlarb]

Control: tags -1 + patch pending fixed-upstream

Hi Andreas,

thank you for your reply!

On 12.01.2017 13:58, Andreas Henriksson wrote:
>> I would very much advocate for at least a backported version of this package
>> containing this patch.
> 
> There's a procedure for getting uploads to stable approved.
> 
> Please start by preparing a (tested) debdiff against the current stable
> package. Contact the Debian Stable Release Managers asking for approval
> of uploading the changes, refer to this bug report and attach the
> debdiff. Once your stable upload has been approved, please feel free
> to poke me if you need someone to sponsor your upload.
> 
> Please see:
> https://www.debian.org/doc/manuals/developers-reference/pkgs.html#upload-stable

I have imported the upstream patch to debian/patches, updated the
changelog, built the package, tested it and attached the debdiff here
(and FWIW uploaded it to
https://mentors.debian.net/package/gnome-settings-daemon).

I will now contact the Debian Stable Release Managers.

Best wishes,
-- 
Moritz Schlarb
Unix-Gruppe | Systembetreuung
Zentrum für Datenverarbeitung
Johannes Gutenberg-Universität Mainz
Raum 01-321 - Tel. +49 6131 39-29441
OpenPGP Fingerprint: DF01 2247 BFC6
5501 AFF2 8445 0C24 B841 C7DD BAAF
-------------- next part --------------
diff -Nru gnome-settings-daemon-3.14.2/debian/changelog gnome-settings-daemon-3.14.2/debian/changelog
--- gnome-settings-daemon-3.14.2/debian/changelog	2015-03-13 22:36:01.000000000 +0100
+++ gnome-settings-daemon-3.14.2/debian/changelog	2017-02-08 10:31:32.000000000 +0100
@@ -1,3 +1,15 @@
+gnome-settings-daemon (3.14.2-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * screenshot-utils-dont-use-spaces-or-colons-in-file.patch:
+    Patch from upstream: https://bugzilla.gnome.org/show_bug.cgi?id=740520
+    Screenshots are often uploaded to web services or copied to (possibly
+    FAT) external drives.
+    Don't use characters that would be incompatible with those.
+    (Closes: #850837)
+
+ -- Moritz Schlarb <schlarbm at uni-mainz.de>  Wed, 08 Feb 2017 10:19:30 +0100
+
 gnome-settings-daemon (3.14.2-3) unstable; urgency=medium
 
   * Team upload
diff -Nru gnome-settings-daemon-3.14.2/debian/patches/screenshot-utils-dont-use-spaces-or-colons-in-file.patch gnome-settings-daemon-3.14.2/debian/patches/screenshot-utils-dont-use-spaces-or-colons-in-file.patch
--- gnome-settings-daemon-3.14.2/debian/patches/screenshot-utils-dont-use-spaces-or-colons-in-file.patch	1970-01-01 01:00:00.000000000 +0100
+++ gnome-settings-daemon-3.14.2/debian/patches/screenshot-utils-dont-use-spaces-or-colons-in-file.patch	2017-02-08 10:14:59.000000000 +0100
@@ -0,0 +1,30 @@
+From 345001ae99b84dbcbeccc86e19d8efee20fec8b0 Mon Sep 17 00:00:00 2001
+From: Cosimo Cecchi <cosimoc at gnome.org>
+Date: Fri, 21 Nov 2014 17:47:23 -0800
+Subject: [PATCH] screenshot-utils: don't use spaces or colons in filenames
+
+Screenshots are often uploaded to web services or copied to (possibly
+FAT) external drives.
+Don't use characters that would be incompatible with those.
+See https://bugzilla.gnome.org/show_bug.cgi?id=698740
+
+https://bugzilla.gnome.org/show_bug.cgi?id=740520
+---
+ plugins/media-keys/gsd-screenshot-utils.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/plugins/media-keys/gsd-screenshot-utils.c b/plugins/media-keys/gsd-screenshot-utils.c
+index c59ee63..242115f 100644
+--- a/plugins/media-keys/gsd-screenshot-utils.c
++++ b/plugins/media-keys/gsd-screenshot-utils.c
+@@ -296,7 +296,7 @@ screenshot_build_filename (void)
+   GDateTime *d;
+ 
+   d = g_date_time_new_now_local ();
+-  origin = g_date_time_format (d, "%Y-%m-%d %H:%M:%S");
++  origin = g_date_time_format (d, "%Y-%m-%d %H-%M-%S");
+   g_date_time_unref (d);
+ 
+   /* translators: this is the name of the file that gets made up
+-- 
+2.1.0
\ No newline at end of file
diff -Nru gnome-settings-daemon-3.14.2/debian/patches/series gnome-settings-daemon-3.14.2/debian/patches/series
--- gnome-settings-daemon-3.14.2/debian/patches/series	2015-03-09 10:49:15.000000000 +0100
+++ gnome-settings-daemon-3.14.2/debian/patches/series	2017-02-08 10:14:59.000000000 +0100
@@ -2,3 +2,4 @@
 04_superP.patch
 30_xrandr_dbus_init.patch
 power-make-sure-to-set-an-error-when-GDBus-set_prope.patch
+screenshot-utils-dont-use-spaces-or-colons-in-file.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: schlarbm.vcf
Type: text/x-vcard
Size: 367 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20170208/9a9cf025/attachment.vcf>