Bug#855955: aisleriot: Variants "Westhaven" and "Diamond-Mine" interfere: crash with wrong-number-of-args

[Ben Wiederhake]

Package: aisleriot
Version: 1:3.22.1-1
Severity: normal

Dear Maintainer,

first of all: I'm unable to run the program with LC_ALL=C, so I'm sorry that
I can only provide the German name.
The German names are "Westhafen" and "Diamantenmine", which translates to
"Westhaven" and "Diamonmine".

The error is an "unexpected scheme error", which appears to be a wrong-number-of-args exception.
If I read the stack trace correctly, then this is due to some remnant code from Diamondmine
calling into code from Westhaven.

Steps to reproduce:
- Start aisleriot
- Select "Diamondmine"
- Quit aisleriot (apparently it's necessary that the *starting* game is Diamondmine)
- Start aisleriot
- Play a full game (not sure in how far this is necessary, but if you play through
  a whole game then it *always* happens.)
- Select "Westhaven"

Expected behavior:
Westhaven starts.

Actual behavior, on my i386 system:
The canvas goes blank (well, background-green), a dialog opens up saying
"Ein Schema-Ausnahmefehler ist aufgetreten
Bitte melden Sie diesen Fehler an die Entwickler.
[Nicht melden] [Melden]"
which translates to something like:
"An unexpected scheme exception occurred
Please report this issue to the developers.
[Don't report] [Report]"
Those brackets are supposed to indicate buttons.

Actual behavior 2, on my amd64 system (used to generate this report) :
Westhaven appears to start normally, but within a few actions (1 or 2, typically),
the above-mentioned dialog pops up.

Clicking "Report" doesn't do anything, and on the console reports that "bug-buddy"
couldn't be launched, which I guess is their intended bug reporter.
Since there doesn't seem to be a package called "bug-buddy",
or any package containing a relevant file [1],
I can't use this (apparently desired) path for this bug report.

After dealing with this error, Westhaven loads successfully, but may intermittently
crash and restart (the particular game, not aisleriot as a whole) during operation.

Manual workaround:
Restart aisleriot so that Westhaven is selected from the very beginning.

Please find attached a generated crash report by aisleriot, on my amd64 system.
I assume that aisleriot attempted to forward these data to "bug-buddy".
It includes stacktraces which indicate that Diamondmine somehow calls into Westhaven,
up to impedance mismatch.

Cheers,
Ben Wiederhake

[1] https://packages.debian.org/search?suite=testing&arch=any&mode=filename&searchon=contents&keywords=bug-buddy


-- System Information:
Debian Release: 9.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages aisleriot depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.26.0-2
ii  gconf-service                                3.2.6-4
ii  gconf2                                       3.2.6-4
ii  guile-2.0-libs                               2.0.13+1-4
ii  libatk1.0-0                                  2.22.0-1
ii  libc6                                        2.24-9
ii  libcairo-gobject2                            1.14.8-1
ii  libcairo2                                    1.14.8-1
ii  libcanberra-gtk3-0                           0.30-3
ii  libcanberra0                                 0.30-3
ii  libgc1c2                                     1:7.4.2-8
ii  libgconf-2-4                                 3.2.6-4
ii  libgdk-pixbuf2.0-0                           2.36.4-1
ii  libglib2.0-0                                 2.50.2-2
ii  libgtk-3-0                                   3.22.7-2
ii  libpango-1.0-0                               1.40.3-3
ii  libpangocairo-1.0-0                          1.40.3-3
ii  librsvg2-2                                   2.40.16-1
ii  libx11-6                                     2:1.6.4-3

Versions of packages aisleriot recommends:
ii  yelp  3.22.0-1

Versions of packages aisleriot suggests:
pn  gnome-cards-data  <none>

-- no debconf information
-------------- next part --------------
Variation: westhaven
Scheme error:
	(#f Wrong number of arguments to ~A (#<procedure find-card (card-suit card-rank slot)>) #f)
Scheme tag:
	wrong-number-of-args

Backtrace:
In ice-9/boot-9.scm:
 160: 8 [catch #t #<catch-closure 557a41bc5220> ...]
In unknown file:
   ?: 7 [apply-smob/1 #<catch-closure 557a41bc5220>]
In ice-9/boot-9.scm:
 160: 6 [catch #t #<catch-closure 557a427a7c80> ...]
In unknown file:
   ?: 5 [apply-smob/1 #<catch-closure 557a427a7c80>]
In westhaven.scm:
 304: 4 [get-hint]
 271: 3 [tableau-to-tableau? 6 10]
In diamond-mine.scm:
 278: 2 [find-card 6 (12 0 #t)]
In ice-9/boot-9.scm:
 105: 1 [#<procedure 557a426c7380 at ice-9/boot-9.scm:100:6 (thrown-k . args)> wrong-number-of-args ...]
In unknown file:
   ?: 0 [apply-smob/1 #<catch-closure 557a427a7c40> wrong-number-of-args ...]


Deck State:
	Slot 0
		(3 3 #f) ,(0 5 #f) ,(0 8 #f)
 ,(3 8 #f) ,(1 13 #f) ,(1 7 #f) ,(3 10 #f) ,(0 4 #f) ,(0 10 #f) ,(3 7 #f) ,(3 12 #f) ,(0 6 #f) ,(2 6 #f) ,(2 11 #f)
	Slot 1
		(Empty)
	Slot 2
		(2 1 #t)
	Slot 3
		(Empty)
	Slot 4
		(Empty)
	Slot 5
		(Empty)
	Slot 6
		(0 1 #f) ,(0 12 #t)
	Slot 7
		(3 2 #f) ,(1 8 #t)
	Slot 8
		(2 12 #f) ,(2 10 #t)
	Slot 9
		(0 2 #f) ,(1 9 #t)
	Slot 10
		(1 10 #f) ,(2 13 #t)
	Slot 11
		(0 9 #f)
	Slot 12
		(3 9 #f) ,(1 3 #t)
	Slot 13
		(2 4 #f) ,(0 13 #t)
	Slot 14
		(3 6 #f) ,(0 3 #t)
	Slot 15
		(1 4 #f) ,(0 11 #t)