Bug#874693: ES6 syntax in 1.48+ breaks packages that redeclare variables with 'let'

[Simon McVittie]

On Thu, 21 Sep 2017 at 07:41:30 -0400, Jeremy Bicha wrote:
> On Fri, Sep 8, 2017 at 2:06 PM, Michael Biebl <biebl at debian.org> wrote:
> > The version from experimental apparently breaks other packages like
> > gnome-weather:
> 
> Yes, I remember now that several GNOME 3.22 packages had to be updated
> to work with gjs 1.48.
...
> To comprehensively "fix" this bug, someone will need to try all the
> GNOME 3.22 gjs-related packages (from stretch) against gjs 1.50
> (rebuilt against stretch to not introduce dependency
> incompatibilities).

For packages that had upstream changes for ES6 compliance, I think we
can safely assume that Breaks are needed, and that the version with the
changes was tested upstream, and just add the Breaks pre-emptively. That
accounts for gnome-characters, -documents, -maps, -weather, polari and
ostree-tests (versions from experimental in some cases, but those can
be part of the libgjs0g transition). I've done that in pkg-gnome svn
for experimental.

gnome-shell doesn't need a Breaks because it already Depends on libgjs0e,
so it's already part of the lockstep upgrade for the libgjs0g transition;
a Breaks would complicate the dependency graph for no benefit.

TODO: gnome-sound-recorder and gnome-sushi haven't had this fixed,
so will need runtime testing to determine whether there is an unfixed
issue or no issue.

TODO: libsecret and libguestfs haven't had this fixed, but only use gjs
for build-time tests anyway, so they will need build-testing to determine
whether there is an unfixed issue or no issue.

Regards,
    smcv