Bug#880176: gtk-doc-tools: crashes if a devhelp2.gz file is present

[Alban Browaeys]

Package: gtk-doc-tools
Version: 1.26-2.1
Severity: important


May you apply upstream patches:
https://git.gnome.org/browse/gtk-doc/commit/?id=d6a75bdf26f61889e5d01e8af499b59b2de011b0
https://git.gnome.org/browse/gtk-doc/commit/?id=6c7c1e571f91997d0895ac6a87f3a417376d0536

I also attach a local patch to fix the testsuite (not yet sent upstream).
I add 18 to the expected log lines count to account for
the upstream patches restored 6 warnings:
"
Please fix https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210 . For now run:
gunzip /usr/share/gtk-doc/html/ogmrip/ogmdvd-gtk/ogmdvd-gtk.devhelp2.gz

"


Local NetworkManager build fails with:
gtkdoc-fixxref --module=libnm --module-dir=html --html-dir=/usr/share/gtk-doc/html 
Traceback (most recent call last):
  File "/usr/bin/gtkdoc-fixxref", line 57, in <module>
    fixxref.Run(options)
  File "/usr/share/gtk-doc/python/gtkdoc/fixxref.py", line 96, in Run
    ScanIndices(options.html_dir, 0)
  File "/usr/share/gtk-doc/python/gtkdoc/fixxref.py", line 153, in ScanIndices
    ScanIndices(subdir, use_absolute_links)
  File "/usr/share/gtk-doc/python/gtkdoc/fixxref.py", line 148, in ScanIndices
    ''' % full_entry)
TypeError: %d format: a number is required, not str
Makefile:869 : la recette pour la cible « html-build.stamp » a échouée
make[3]: *** [html-build.stamp] Erreur 1
make[3] : on quitte le répertoire « /home/prahal/nm-online/network-manager-1.8.4/docs/libnm »
Makefile:15802 : la recette pour la cible « all-recursive » a échouée
make[2]: *** [all-recursive] Erreur 1
make[2] : on quitte le répertoire « /home/prahal/nm-online/network-manager-1.8.4 »
Makefile:6532 : la recette pour la cible « all » a échouée
make[1]: *** [all] Erreur 2
make[1] : on quitte le répertoire « /home/prahal/nm-online/network-manager-1.8.4 »
dh_auto_build: make -j10 returned exit code 2
debian/rules:8 : la recette pour la cible « build » a échouée
make: *** [build] Erreur 2
dpkg-buildpackage: erreur: debian/rules build subprocess returned exit status 2


-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 'unstable'), (500, 'stable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gtk-doc-tools depends on:
ii  docbook-to-man  1:2.0.0-39
ii  docbook-xml     4.5-8
ii  docbook-xsl     1.79.1+dfsg-2
ii  highlight       3.39-1
ii  libglib2.0-dev  2.54.2-1.1
ii  pkg-config      0.29-4+b1
ii  python          2.7.14-1
ii  python-mock     2.0.0-3
ii  python-six      1.11.0-1
ii  xsltproc        1.1.29-2.2

gtk-doc-tools recommends no packages.

Versions of packages gtk-doc-tools suggests:
ii  dblatex  0.3.10-2

-- no debconf information
-------------- next part --------------
--- a/tests/sanity.sh
+++ b/tests/sanity.sh
@@ -82,15 +82,17 @@
 tested=`expr $tested + 1`
 
 # check that log files have only one line (the command)
+# and the 6 references to launchapd bug 1466210
+# which makes up 19 lines
 nok=0
 for file in $dir/*/docs/gtkdoc-*.log; do
-  expected_lines="1"
+  expected_lines="19"
   # adjust for known files
   if test $file = "$dir/fail/docs/gtkdoc-mkdb.log"; then
-    expected_lines="16"
+    expected_lines="34"
   fi
   if test $file = "$dir/gobject/docs/gtkdoc-fixxref.log"; then
-    expected_lines="2"
+    expected_lines="20"
   fi
   case $file in
   *gtkdoc-fixxref.log)