Bug#875704: gdk-pixbuf: please make the output of gdk-pixbuf-query-loaders reproducible

[Chris Lamb]

Source: gdk-pixbuf
Version: 2.36.5-4
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: toolchain filesystemordering
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that the output from gdk-pixbuf's gdk-pixbuf-query-loaders was
not reproducible

This is because libgdk-pixbuf2.0-0's postinst script iterates over
the filesystem without sorting. It was found whilst testing the Tails
[1] ISO for reproducibility issues.

Patch attached.

 [0] https://reproducible-builds.org/
 [1] https://tails.boum.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
diff --git a/debian/libgdk-pixbuf2.0-0.postinst.in b/debian/libgdk-pixbuf2.0-0.postinst.in
index 91b34cd..e9071cd 100644
--- a/debian/libgdk-pixbuf2.0-0.postinst.in
+++ b/debian/libgdk-pixbuf2.0-0.postinst.in
@@ -14,7 +14,7 @@ if [ "$1" = triggered ]; then
             # This is triggered everytime an application installs a
             # GdkPixbuf loader
             /usr/lib/#MULTIARCH#/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders \
-                $(find $LOADERS_DIR $LOADERS_DIR_OLD -name *.so 2> /dev/null) \
+                $(find $LOADERS_DIR $LOADERS_DIR_OLD -name *.so 2> /dev/null | LC_ALL=C sort) \
             > /usr/lib/#MULTIARCH#/gdk-pixbuf-2.0/2.10.0/loaders.cache || true
             ;;
         esac
@@ -28,6 +28,6 @@ fi
 # Also handle the initial installation
 if [ -d $LOADERS_DIR ] || [ -d $LOADERS_DIR_OLD ]; then
     /usr/lib/#MULTIARCH#/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders \
-        $(find $LOADERS_DIR $LOADERS_DIR_OLD -name *.so 2> /dev/null) \
+        $(find $LOADERS_DIR $LOADERS_DIR_OLD -name *.so 2> /dev/null | LC_ALL sort) \
     > /usr/lib/#MULTIARCH#/gdk-pixbuf-2.0/2.10.0/loaders.cache || true
 fi