Bug#895043: libgtk-3-0: unexplained downstream patch disables VIQR input method in Vietnamese locales

[Simon McVittie]

Package: libgtk-3-0
Version: 3.22.29-3
Severity: normal
Tags: help
X-Debbugs-Cc: debian-l10n-vietnamese at lists.debian.org, ubuntu-desktop at lists.ubuntu.com

The Debian packages for GTK+ 2 and GTK+ 3 both have the patch quoted
below, which changes the upstream default behaviour. It was applied with
the comment "imported from Ubuntu" and no further information. As far as
I can tell, instead of enabling the VIQR Vietnamese input method in vi_*
locales, it leaves it disabled in all locales unless explicitly enabled.
It isn't clear why this change is desirable.

If this change is good for Vietnamese-speaking users of Debian and Ubuntu,
we should explain why in the patch metadata, apply it to GTK+ 4, and (if
the reason isn't completely Debian-specific) send it upstream. Conversely,
if it's a bad change, we should consider reverting it.

Can anyone shed some light on this?

(I don't know anything about Vietnamese input methods, the Vietnamese
language or VIQR; my only goal here is that whenever we patch an
important library, we should be able to justify why.)

Thanks,
    smcv

From: Ubuntu Core Developers <ubuntu-devel-discuss at lists.ubuntu.com>
Date: Tue, 3 Mar 2009 21:58:20 -0300
Subject: Disable VIQR IM for vi locale

[TODO: why? The Debian changelog just says "imported from Ubuntu"]

Forwarded: no
---
 modules/input/imviqr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/input/imviqr.c b/modules/input/imviqr.c
index d9572f5..bfa4462 100644
--- a/modules/input/imviqr.c
+++ b/modules/input/imviqr.c
@@ -242,7 +242,7 @@ static const GtkIMContextInfo viqr_info = {
   NC_("input method menu", "Vietnamese (VIQR)"), /* Human readable name */
   GETTEXT_PACKAGE,	   /* Translation domain */
    GTK_LOCALEDIR,	   /* Dir for bindtextdomain (not strictly needed for "gtk+") */
-  "vi"			   /* Languages for which this module is the default */
+  ""			   /* Languages for which this module is the default */
 };
 
 static const GtkIMContextInfo *info_list[] = {