Bug#906214: polari: conditional catch clauses are incompatible with mozjs60 (gjs 1.53.90+)

[Simon McVittie]

Package: polari
Version: 3.28.0-1
Severity: important
Tags: upstream buster sid
Control: block 906016 by -1

gjs 1.53.90+ switches its Javascript implementation from mozjs52 to
mozjs60, a newer Mozilla Spidermonkey release which drops some
Mozilla-proprietary extensions. A gjs maintainer has developed a tool,
<https://gitlab.gnome.org/ptomato/moz60tool>, which can be used to check
for most of the problem cases.

When I ran that tool against polari I got warnings:

polari/src/application.js:466:16: Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }
polari/src/application.js:737:16: Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }
polari/src/mainWindow.js:255:16: Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }

This has probably been fixed upstream for GNOME 3.30. The GNOME team is
in the process of uploading GNOME 3.30 libraries to experimental, which
might be required for a new upstream version of polari.

gjs will need to have a Breaks against unfixed polari versions.

Regards,
    smcv

-- System Information:
Debian Release: buster/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.17.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages polari depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.28.0-2
ii  gir1.2-gdkpixbuf-2.0                         2.36.12-1
ii  gir1.2-glib-2.0                              1.56.1-1
pn  gir1.2-gspell-1                              <none>
ii  gir1.2-gtk-3.0                               3.22.30-2
ii  gir1.2-pango-1.0                             1.42.1-2
ii  gir1.2-secret-1                              0.18.6-2
ii  gir1.2-soup-2.4                              2.62.2-2
ii  gir1.2-telepathyglib-0.12                    0.24.1-2
ii  gir1.2-telepathylogger-0.2                   0.8.2-3
ii  gjs                                          1.52.3-2
ii  libc6                                        2.27-5
ii  libgirepository-1.0-1                        1.56.1-1
ii  libgjs0g [libgjs0-libmozjs-52-0]             1.52.3-2
ii  libglib2.0-0                                 2.57.2-1
pn  libglib2.0-bin                               <none>
ii  libgtk-3-0                                   3.22.30-2
ii  libtelepathy-glib0                           0.24.1-2
pn  telepathy-idle                               <none>
pn  telepathy-logger                             <none>
ii  telepathy-mission-control-5                  1:5.16.4-2

polari recommends no packages.

polari suggests no packages.