Bug#917639: gnome-disk-utility FTCBFS: broken fallocate check

[Helmut Grohne]

Source: gnome-disk-utility
Version: 3.30.2-2
Tags: patch upstream
User: helmutg at debian.org
Usertags: rebootstrap

gnome-disk-utility fails to cross build from source, because it fails
checking for fallocate. Now, a surprising journey begins. For checking
fallocate, it has a test program that lacks the required "#define
_GNU_SOURCE" and is missing a final "return 0". So the check result is
undefined. It proceeds storing the (undefined) return code in a C macro
HAVE_FALLOCATE and then in the source, it checks whether that macro is
defined. Given that the macro is always defined (with undefined
contents), gnome-disk-utility always compiles support for fallocate.
That's actually a good thing, because it correctly handles -ENOSYS and
-EOPNOTSUPP. I propose simply removing the broken check that never
worked and continuing to unconditionally compile fallocate support. The
attached patch (which only removes code) makes gnome-disk-utility cross
buildable.  Please consider applying it.

Helmut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cross.patch
Type: text/x-diff
Size: 1398 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gnome-maintainers/attachments/20181229/6ce47f40/attachment.patch>