Bug#888608: gnome-shell-extensions: places menu accesses a destroyed Gio.DBusProxy

[Simon McVittie]

Package: gnome-shell-extensions
Version: 3.26.2-2
Severity: normal
Tags: patch fixed-upstream

After fixing the crash in #888485, gnome-shell with gjs >= 1.50.2-3 and
the Places Menu extension logs warnings like these:

> jan 27 10:14:06 sonata gnome-shell[1764]: Object Gio.DBusProxy (0x55d13d734f50), has been already deallocated - impossible to access to it. This might be caused by the fact that the object has been destroyed
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: == Stack trace for context 0x55d139f99170 ==
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #0 0x7ffc20b6fe90 b   resource:///org/gnome/gjs/modules/overrides/Gio.js:197 (0x7f75a4403d58 @ 26)
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: == Stack trace for context 0x55d139f99170 ==
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #0 0x55d13a4dbc50 i   /home/manuel/.local/share/gnome-shell/extensions/places-menu at gnome-shell-extensions.gcampax.github.com/placeDisplay.js:146 (0x7f758
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #1 0x7ffc20b6f6e0 I   self-hosted:917 (0x7f75a46ee5e8 @ 394)
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #2 0x7ffc20b6fe90 b   resource:///org/gnome/gjs/modules/overrides/Gio.js:203 (0x7f75a4403d58 @ 89)
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: == Stack trace for context 0x55d139f99170 ==
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #0 0x55d13a4dbcf8 i   /home/manuel/.local/share/gnome-shell/extensions/places-menu at gnome-shell-extensions.gcampax.github.com/placeDisplay.js:159 (0x7f758
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #1 0x7ffc20b6eae0 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f75a46c2bc0 @ 71)
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #2 0x55d13a4dbc50 i   /home/manuel/.local/share/gnome-shell/extensions/places-menu at gnome-shell-extensions.gcampax.github.com/placeDisplay.js:148 (0x7f758
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #3 0x7ffc20b6f6e0 I   self-hosted:917 (0x7f75a46ee5e8 @ 394)
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #4 0x7ffc20b6fe90 b   resource:///org/gnome/gjs/modules/overrides/Gio.js:203 (0x7f75a4403d58 @ 89)
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: == Stack trace for context 0x55d139f99170 ==
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #0 0x7ffc20b6fe90 b   resource:///org/gnome/gjs/modules/overrides/Gio.js:197 (0x7f75a4403d58 @ 26)
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: == Stack trace for context 0x55d139f99170 ==
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #0 0x55d13a4dbc50 i   /home/manuel/.local/share/gnome-shell/extensions/places-menu at gnome-shell-extensions.gcampax.github.com/placeDisplay.js:146 (0x7f758
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #1 0x7ffc20b6f6e0 I   self-hosted:917 (0x7f75a46ee5e8 @ 394)
> jan 27 10:14:06 sonata org.gnome.Shell.desktop[1764]: #2 0x7ffc20b6fe90 b   resource:///org/gnome/gjs/modules/overrides/Gio.js:203 (0x7f75a4403d58 @ 89)

See also #888485, #888052.

I believe this is fixed by this upstream commit:
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/commit/3284fe81d7cdb362fc7d8013bf7d958b253c4b44

I deliberately haven't fixed this yet, because it's the only way I know
of to reproduce the crash seen in #888485, which is a lot more serious
than some warnings; and I'd like to be able to be sure that we've really
fixed that crash before removing the only way I can reproduce it.

    smcv