Bug#894103: rhythmbox FTBFS: error: pasting ""rbsilencesrc"" and "_get_desc" does not give a valid preprocessing token

[Simon McVittie]

Control: tags -1 + patch fixed-upstream
Control: forwarded -1 https://bugzilla.gnome.org/show_bug.cgi?id=788706

On Mon, 26 Mar 2018 at 16:11:31 +0300, Adrian Bunk wrote:
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/rhythmbox.html
> 
> ...
> In file included from /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:9:0,
>                  from /usr/include/glib-2.0/glib/gtypes.h:32,
>                  from /usr/include/glib-2.0/glib/galloca.h:32,
>                  from /usr/include/glib-2.0/glib.h:30,
>                  from ../../lib/rb-debug.h:33,
>                  from rb-fm-radio-gst-src.c:33:
> rb-fm-radio-gst-src.c:181:6: error: pasting ""rbsilencesrc"" and "_get_desc" does not give a valid preprocessing token
>       "rbsilencesrc",
>       ^

Looks like a regression triggered by
https://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=e7ede5a487d8c1571a4387a5f8eeb4d5e73a9553
in GStreamer 1.13/1.14. It seems this argument to the GST_PLUGIN_DEFINE
macro was always meant to be an unquoted string in the style of an
identifier (the macro wraps it in G_STRINGIFY, turning it from name into
#name), but because it wasn't previously used in token pasting, nobody
noticed that this particular plugin had the unusual name '"rbsilencesrc"'
(including the double quotes).

    smcv