Bug#907940: gnome-boxes FTBFS with vala 0.42.0-1

[Adrian Bunk]

Source: gnome-boxes
Version: 3.28.5-1
Severity: serious
Tags: ftbfs

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/gnome-boxes.html

...
FAILED: src/src@@gnome-boxes at exe/app.c src/src@@gnome-boxes at exe/app-window.c src/src@@gnome-boxes at exe/actions-popover.c src/src@@gnome-boxes at exe/archive-reader.c src/src@@gnome-boxes at exe/archive-writer.c src/src@@gnome-boxes at exe/auth-notification.c src/src@@gnome-boxes at exe/collection.c src/src@@gnome-boxes at exe/collection-filter-switcher.c src/src@@gnome-boxes at exe/collection-toolbar.c src/src@@gnome-boxes at exe/display-page.c src/src@@gnome-boxes at exe/display-toolbar.c src/src@@gnome-boxes at exe/display.c src/src@@gnome-boxes at exe/editable-entry.c src/src@@gnome-boxes at exe/i-properties-provider.c src/src@@gnome-boxes at exe/i-collection-view.c src/src@@gnome-boxes at exe/icon-view.c src/src@@gnome-boxes at exe/installer-media.c src/src@@gnome-boxes at exe/installed-media.c src/src@@gnome-boxes at exe/keys-input-popover.c src/src@@gnome-boxes at exe/libvirt-cloned-media.c src/src@@gnome-boxes at exe/libvirt-media.c src/src@@gnome-boxes at exe/iso-extractor.c src/src@@gnome-boxes at exe/icon-view-child.c src/src@@gnome-boxes at exe/libvirt-broker.c src/src@@gnome-boxes at exe/libvirt-machine.c src/src@@gnome-boxes at exe/libvirt-machine-properties.c src/src@@gnome-boxes at exe/list-view.c src/src@@gnome-boxes at exe/list-view-row.c src/src@@gnome-boxes at exe/machine.c src/src@@gnome-boxes at exe/machine-thumbnailer.c src/src@@gnome-boxes at exe/main.c src/src@@gnome-boxes at exe/media-manager.c src/src@@gnome-boxes at exe/resource-graph.c src/src@@gnome-boxes at exe/notification.c src/src@@gnome-boxes at exe/notificationbar.c src/src@@gnome-boxes at exe/os-database.c src/src@@gnome-boxes at exe/properties.c src/src@@gnome-boxes at exe/properties-window.c src/src@@gnome-boxes at exe/properties-page-widget.c src/src@@gnome-boxes at exe/properties-toolbar.c src/src@@gnome-boxes at exe/remote-machine.c src/src@@gnome-boxes at exe/searchbar.c src/src@@gnome-boxes at exe/selectionbar.c src/src@@gnome-boxes at exe/selection-toolbar.c src/src@@gnome-boxes at exe/shared-folder-popover.c src/src@@gnome-boxes at exe/spice-display.c src/src@@gnome-boxes at exe/transfer-info-row.c src/src@@gnome-boxes at exe/transfer-popover.c src/src@@gnome-boxes at exe/troubleshoot-view.c src/src@@gnome-boxes at exe/topbar.c src/src@@gnome-boxes at exe/ui.c src/src@@gnome-boxes at exe/unattended-installer.c src/src@@gnome-boxes at exe/unattended-file.c src/src@@gnome-boxes at exe/unattended-setup-box.c src/src@@gnome-boxes at exe/util-app.c src/src@@gnome-boxes at exe/vm-configurator.c src/src@@gnome-boxes at exe/vm-creator.c src/src@@gnome-boxes at exe/vm-importer.c src/src@@gnome-boxes at exe/libvirt-system-importer.c src/src@@gnome-boxes at exe/libvirt-vm-cloner.c src/src@@gnome-boxes at exe/libvirt-vm-importer.c src/src@@gnome-boxes at exe/vnc-display.c src/src@@gnome-boxes at exe/wizard-window.c src/src@@gnome-boxes at exe/wizard-source.c src/src@@gnome-boxes at exe/wizard-toolbar.c src/src@@gnome-boxes at exe/wizard.c src/src@@gnome-boxes at exe/downloader.c src/src@@gnome-boxes at exe/empty-boxes.c src/src@@gnome-boxes at exe/tracker-iso-query.c src/src@@gnome-boxes at exe/troubleshoot-log.c src/src@@gnome-boxes at exe/snapshot-list-row.c src/src@@gnome-boxes at exe/snapshots-property.c src/src@@gnome-boxes at exe/ovirt-broker.c src/src@@gnome-boxes at exe/ovirt-machine.c 
valac -C --pkg rest-0.7 --pkg govirt-1.0 --pkg gudev-1.0 --pkg spice-client-gtk-3.0 --pkg posix --pkg linux /build/1st/gnome-boxes-3.28.5/vapi/gio-2.0-workaround.vapi --pkg webkit2gtk-4.0 --pkg tracker-sparql-2.0 --pkg spice-client-gtk-3.0 --pkg libxml-2.0 --pkg libvirt-gobject-1.0 --pkg libvirt-gconfig-1.0 --pkg libusb-1.0 --pkg libsoup-2.4 --pkg libsecret-1 --pkg libosinfo-1.0 --pkg gtk-vnc-2.0 --pkg gtk+-3.0 --pkg gobject-2.0 --pkg libarchive /build/1st/gnome-boxes-3.28.5/src/config.vapi --color=always --directory src/src@@gnome-boxes at exe --basedir ../src --gresources=../data/gnome-boxes.gresource.xml --enable-experimental --vapidir /build/1st/gnome-boxes-3.28.5/vapi --vapidir /build/1st/gnome-boxes-3.28.5/vapi/upstream --target-glib=2.38 --define=HAVE_OVIRT ../src/app.vala ../src/app-window.vala ../src/actions-popover.vala ../src/archive-reader.vala ../src/archive-writer.vala ../src/auth-notification.vala ../src/collection.vala ../src/collection-filter-switcher.vala ../src/collection-toolbar.vala ../src/display-page.vala ../src/display-toolbar.vala ../src/display.vala ../src/editable-entry.vala ../src/i-properties-provider.vala ../src/i-collection-view.vala ../src/icon-view.vala ../src/installer-media.vala ../src/installed-media.vala ../src/keys-input-popover.vala ../src/libvirt-cloned-media.vala ../src/libvirt-media.vala ../src/iso-extractor.vala ../src/icon-view-child.vala ../src/libvirt-broker.vala ../src/libvirt-machine.vala ../src/libvirt-machine-properties.vala ../src/list-view.vala ../src/list-view-row.vala ../src/machine.vala ../src/machine-thumbnailer.vala ../src/main.vala ../src/media-manager.vala ../src/resource-graph.vala ../src/notification.vala ../src/notificationbar.vala ../src/os-database.vala ../src/properties.vala ../src/properties-window.vala ../src/properties-page-widget.vala ../src/properties-toolbar.vala ../src/remote-machine.vala ../src/searchbar.vala ../src/selectionbar.vala ../src/selection-toolbar.vala ../src/shared-folder-popover.vala ../src/spice-display.vala ../src/transfer-info-row.vala ../src/transfer-popover.vala ../src/troubleshoot-view.vala ../src/topbar.vala ../src/ui.vala ../src/unattended-installer.vala ../src/unattended-file.vala ../src/unattended-setup-box.vala ../src/util-app.vala ../src/vm-configurator.vala ../src/vm-creator.vala ../src/vm-importer.vala ../src/libvirt-system-importer.vala ../src/libvirt-vm-cloner.vala ../src/libvirt-vm-importer.vala ../src/vnc-display.vala ../src/wizard-window.vala ../src/wizard-source.vala ../src/wizard-toolbar.vala ../src/wizard.vala ../src/downloader.vala ../src/empty-boxes.vala ../src/tracker-iso-query.vala ../src/troubleshoot-log.vala ../src/snapshot-list-row.vala ../src/snapshots-property.vala ../src/ovirt-broker.vala ../src/ovirt-machine.vala src/common.vapi
../src/collection.vala:132.5-132.57: error: Property `Boxes.CollectionFilter.filter_func' with custom `get' accessor and/or `set' mutator cannot have `default' value
    public unowned Boxes.CollectionFilterFunc filter_func {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/archive-writer.vala:126.33-126.36: error: Argument 1: Cannot convert from `void*' to `unowned uint8[]'
        if (archive.write_data (data, (size_t) len) != len)
                                ^^^^
../src/archive-writer.vala:75.35-75.86: error: 1 extra arguments for `ssize_t Archive.Read.read_data (uint8[])'
                insert_data (buf, archive_reader.archive.read_data (buf, (size_t) len));
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/common.vapi:8.4-8.46: warning: DBus methods are recommended to throw at least `GLib.Error' or `GLib.DBusError, GLib.IOError'
			public abstract async string FindUserByName (string name) throws GLib.IOError;
			^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/resource-graph.vala:63.40-63.61: warning: Gtk.StyleContext.get_border_color has been deprecated since 3.16
../src/editable-entry.vala:120.9-120.27: warning: Gtk.Widget.override_font has been deprecated since 3.16
../src/editable-entry.vala:121.20-121.54: warning: Gtk.StyleContext.get_font has been deprecated since 3.8
../src/editable-entry.vala:126.9-126.27: warning: Gtk.Widget.override_font has been deprecated since 3.16
../src/snapshot-list-row.vala:77.26-77.48: warning: Gtk.StyleContext.get_background_color has been deprecated since 3.16
../src/wizard-source.vala:371.28-371.44: warning: Gdk.Screen.height has been deprecated since 3.22
../src/icon-view-child.vala:22.5-22.24: error: Property `Boxes.IconViewChild.selected' with custom `get' accessor and/or `set' mutator cannot have `default' value
    public bool selected {
    ^^^^^^^^^^^^^^^^^^^^
../src/icon-view-child.vala:8.5-8.30: error: Property `Boxes.IconViewChild.selection_mode' with custom `get' accessor and/or `set' mutator cannot have `default' value
    public bool selection_mode {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/list-view-row.vala:28.5-28.24: error: Property `Boxes.ListViewRow.selected' with custom `get' accessor and/or `set' mutator cannot have `default' value
    public bool selected {
    ^^^^^^^^^^^^^^^^^^^^
../src/list-view-row.vala:14.5-14.30: error: Property `Boxes.ListViewRow.selection_mode' with custom `get' accessor and/or `set' mutator cannot have `default' value
    public bool selection_mode {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 7 error(s), 7 warning(s)
...