Bug#908309: gdk-pixbuf: please make the build reproducible

[Chris Lamb]

Source: gdk-pixbuf
Version: 2.36.12-2
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that gdk-pixbuf could not be built reproducibly.

This is because "@filename@" gets expanded to the full, absolute path
name. Patch attached that uses "@basename@" instead.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/gdk-pixbuf/gdk-pixbuf-enum-types.c.template	2018-09-08 10:35:57.774540239 +0100
--- b/gdk-pixbuf/gdk-pixbuf-enum-types.c.template	2018-09-08 10:43:51.053523569 +0100
@@ -6,7 +6,7 @@
 /*** END file-header ***/
 
 /*** BEGIN file-production ***/
-/* enumerations from "@filename@" */
+/* enumerations from "@basename@" */
 /*** END file-production ***/
 
 /*** BEGIN value-header ***/
--- a/gdk-pixbuf/gdk-pixbuf-enum-types.h.template	2018-09-08 10:35:57.774540239 +0100
--- b/gdk-pixbuf/gdk-pixbuf-enum-types.h.template	2018-09-08 10:43:51.033523444 +0100
@@ -15,7 +15,7 @@
 
 /*** BEGIN file-production ***/
 
-/* enumerations from "@filename@" */
+/* enumerations from "@basename@" */
 /*** END file-production ***/
 
 /*** BEGIN value-header ***/
--- a/gdk-pixbuf/makefile.msc	2018-09-08 10:35:57.774540239 +0100
--- b/gdk-pixbuf/makefile.msc	2018-09-08 10:43:50.997523217 +0100
@@ -162,7 +162,7 @@
 gdk-pixbuf-enum-types.h : $(gdk_pixbuf_headers) makefile.msc
 	$(PERL) $(GLIB)\gobject\glib-mkenums \
 		--fhead "#ifndef __GDK_PIXBUF__ENUM_TYPES_H__\n#define __GDK_PIXBUF_ENUM_TYPES_H__\n" \
-		--fprod "/* enumerations from \"@filename@\" */\n" \
+		--fprod "/* enumerations from \"@basename@\" */\n" \
 		--vhead "GType @enum_name at _get_type (void);\n#define GDK_TYPE_ at ENUMSHORT@ (@enum_name at _get_type())\n"         \
 		--ftail "#endif /* __GDK_PIXBUF_ENUM_TYPES_H__ */" \
 		$(gdk_pixbuf_headers) ) > gdk-pixbuf-enum-types.h
@@ -173,7 +173,7 @@
 gdk-pixbuf-enum-types.c: $(gdk_pixbuf_headers) makefile.msc
 	$(PERL) $(GLIB)\gobject\glib-mkenums \
 		--fhead "#include <gdk-pixbuf/gdk-pixbuf.h>" \
-		--fprod "\n/* enumerations from \"@filename@\" */" \
+		--fprod "\n/* enumerations from \"@basename@\" */" \
 		--vhead "GType\n at enum_name@_get_type (void)\n{\n  static GType etype = 0;\n  if (etype == 0) {\n    static const G at Type@Value values[] = {"       \
 		--vprod "      { @VALUENAME@, \"@VALUENAME@\", \"@valuenick@\" }," \
 		--vtail "      { 0, NULL, NULL }\n    };\n    etype = g_ at type@_register_static (\"@EnumName@\", values);\n  }\n  return etype;\n}\n" \