Bug#908373: gdk-pixbuf: Please honour "nocheck" in DEB_BUILD_OPTIONS

[John Paul Adrian Glaubitz]

Source: gdk-pixbuf
Version: 2.38.0+dfsg-3
Severity: normal

Hello!

Since version 2.38.0+dfsg-2, gdk-pixbuf is ignoring "nocheck" in
DEB_BUILD_OPTIONS which means the testsuite is always run which
means it's no longer to cross-build the package as the testsuite
can only run during native builds.

It also means the package can fail in emulated build environments
with QEMU where we explicitly disable testsuites with nocheck.

The problem is this line [1] which uncondtionally runs the tests:


override_dh_auto_test:
	# on slow arches the "slow" tests take longer than the timeout allowed
	# by upstream; allow even more time (-t is a multipiler)
	meson test -C $(CURDIR)/obj-$(DEB_HOST_GNU_TYPE) -t 5

You need to guard this with:

ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
endif

Would be great if this minor change could be included in the next
upload.

Thanks,
Adrian

> [1] https://salsa.debian.org/gnome-team/gdk-pixbuf/blob/debian/master/debian/rules#L23

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913