Bug#927980: unblock: librsvg/2.44.10-2.1 (pre-approval)

[Boyuan Yang]

Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock
X-Debbugs-CC: pkg-gnome-maintainers at lists.alioth.debian.org
927886 at bugs.debian.org

Hello all,

I have prepared an NMU to fix bug https://bugs.debian.org/927886 .
This bug in librsvg caused deepin-image-viewer to crash on startup.
The patch is picked
from upstream git trunk. The full debdiff is pasted in this mail.

I have confirmed that deepin-image-viewer will no longer crash with this patch.

The upload hasn't been made yet. Please let me know if it looks okay
to you and I'll upload the NMU later.

--
Thanks,
Boyuan Yang

diff -Nru librsvg-2.44.10/debian/changelog librsvg-2.44.10/debian/changelog
--- librsvg-2.44.10/debian/changelog    2019-04-11 04:29:30.000000000 -0400
+++ librsvg-2.44.10/debian/changelog    2019-04-25 15:55:18.000000000 -0400
@@ -1,3 +1,12 @@
+librsvg (2.44.10-2.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * debian/patches/keep-positive-radii.patch: backport an upstream fix for
+    an assertion error where radii should always be positive
+    (Closes: #927886)
+
+ -- Boyuan Yang <byang at debian.org>  Thu, 25 Apr 2019 15:55:18 -0400
+
 librsvg (2.44.10-2) unstable; urgency=medium

   * debian/patches/typenum-i386-ftbfs.patch: backport an upstream fix for a
diff -Nru librsvg-2.44.10/debian/patches/keep-positive-radii.patch
librsvg-2.44.10/debian/patches/keep-positive-radii.patch
--- librsvg-2.44.10/debian/patches/keep-positive-radii.patch
1969-12-31 19:00:00.000000000 -0500
+++ librsvg-2.44.10/debian/patches/keep-positive-radii.patch
2019-04-25 15:52:27.000000000 -0400
@@ -0,0 +1,33 @@
+From: Federico Mena Quintero <federico at gnome.org>
+Date: Sat, 29 Dec 2018 12:32:08 -0600
+Subject: Morphology needs positive radii even after the transformation
+
+This is the same pattern as in gaussian_blur.rs; the paffine
+transformation can leave us with negative radii, so take their
+absolute value after the transformation.
+
+This fixes assertion error (crashing) when nagative r takes place.
+
+Forwarded: https://gitlab.gnome.org/GNOME/librsvg/issues/395
+Applied-Upstream:
https://gitlab.gnome.org/GNOME/librsvg/commit/4ef7f198fceb8fb4a544f4768174af5b11fc9bcc
+Bug-Debian: https://bugs.debian.org/927886
+Signed-off-by: Boyuan Yang <byang at debian.org>
+---
+ rsvg_internals/src/filters/morphology.rs | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/rsvg_internals/src/filters/morphology.rs
b/rsvg_internals/src/filters/morphology.rs
+index 60fbcef..7de1a0d 100644
+--- a/rsvg_internals/src/filters/morphology.rs
++++ b/rsvg_internals/src/filters/morphology.rs
+@@ -95,6 +95,10 @@ impl Filter for Morphology {
+         let (rx, ry) = self.radius.get();
+         let (rx, ry) = ctx.paffine().transform_distance(rx, ry);
+
++        // The radii can become negative here due to the transform.
++        let rx = rx.abs();
++        let ry = ry.abs();
++
+         let operator = self.operator.get();
+
+         let mut output_surface = ImageSurface::create(
diff -Nru librsvg-2.44.10/debian/patches/series
librsvg-2.44.10/debian/patches/series
--- librsvg-2.44.10/debian/patches/series    2019-04-11 04:29:30.000000000 -0400
+++ librsvg-2.44.10/debian/patches/series    2019-04-25 15:54:21.000000000 -0400
@@ -1,3 +1,4 @@
 10_rsvg-gz.patch
 typenum-i386-ftbfs.patch
 i386-rounding-errors.patch
+keep-positive-radii.patch