Bug#935075: Incorrect city code for Lima, Perú. Missing weather information.

[Diego Escalante Urrelo]

Package: libgweather-common
Version: 3.28.2-2
Severity: normal
Tags: l10n

Some time in 2015 Lima changed its airport code, libgweather upstream
corrected that here:
    https://gitlab.gnome.org/GNOME/libgweather/commit/6a79e8871e3e74ef276f24158735172ff6af1819

It's super simple to change and you can change it on a running system:
    /usr/share/libgweather/Locations.xml

HOWEVER, there's a catch: gnome-weather crashes if it tries to start
with unknown locations configured in:
    dconf read /org/gnome/Weather/Application/locations

Fixing the airport code can lead to an ugly situation:
    1. libgweather-common is updated to SPJC
    2. an affected system has SPIM location in gnome-weather (whether
    explicitly set, or from "automatic location")
    3. gnome-weather no longer starts

        (org.gnome.Weather.Application:8109): Gjs-WARNING **: 01:01:29.002: JS ERROR: TypeError: location is null
        _onLocationAdded at resource:///org/gnome/Weather/Application/js/app/world.js:151:13
        wrapper at resource:///org/gnome/gjs/modules/_legacy.js:82:22
        _init at resource:///org/gnome/Weather/Application/js/app/world.js:115:13
        wrapper at resource:///org/gnome/gjs/modules/_legacy.js:82:22
        _init at resource:///org/gnome/Weather/Application/js/app/window.js:65:27
        wrapper at resource:///org/gnome/gjs/modules/_legacy.js:82:22
        _createWindow at resource:///org/gnome/Weather/Application/js/app/main.js:159:16
        wrapper at resource:///org/gnome/gjs/modules/_legacy.js:82:22
        vfunc_activate at resource:///org/gnome/Weather/Application/js/app/main.js:191:19
        wrapper at resource:///org/gnome/gjs/modules/_legacy.js:82:22
        main at resource:///org/gnome/Weather/Application/js/app/main.js:207:13
        run at resource:///org/gnome/gjs/modules/package.js:225:12
        @/usr/bin/gnome-weather:6:1

gnome-weather upstream master corrects invalid locations on the fly, I
believe thanks to these commits:
    https://gitlab.gnome.org/GNOME/gnome-weather/commit/f07286f13a3daf8fa5a44da8dfeef36e9df44ed0
    https://gitlab.gnome.org/GNOME/gnome-weather/commit/01bf03ab8cf805a5a2706a03c5615b42c020e41f

I haven't tried to patch gnome-weather locally on my system, so I don't
know if those apply cleanly (it would seem gnome-weather haven't seen
much changes anyway).

Sadly this bug breaks weather information for Lima, and the fix is non
trivial for end users. Equally sad that I can't provide you with a patch
as I'm a bit out of my zone when it comes to stable-respecting patches
and backporting stuff like this.

Thanks for your kind work packaging GNOME.


-- System Information:
Debian Release: 10.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libgweather-common depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.30.1-2

libgweather-common recommends no packages.

libgweather-common suggests no packages.

-- no debconf information