Bug#922681: libsecret-1-0: Returns an invalid pointer if an item does not have a schema name

[Alberto Garcia]

Package: libsecret-1-0
Version: 0.18.5-3.1
Severity: important
Tags: upstream patch

Hi!

The version of libsecret available in Debian stretch returns an
invalid pointer if you call secret_item_get_schema_name() on an item
that does not have a schema name.

This crashes e.g. Seahorse:

Thread 1 "seahorse" received signal SIGSEGV, Segmentation fault.
__strcmp_sse2_unaligned () at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:31
31      ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S: No such file or directory.
(gdb) bt
#0  __strcmp_sse2_unaligned () at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:31
#1  0x000055555560676b in check_object_type (object=0x555555da12c0, user_data=0x0) at libseahorse/seahorse-search-provider.c:488
#2  0x0000555555602076 in seahorse_predicate_match (pred=0x5555558e8890, obj=0x555555da12c0) at libseahorse/seahorse-predicate.c:70
#3  0x00005555555fa162 in maybe_add_object (self=0x5555558deca0, obj=0x555555da12c0) at libseahorse/seahorse-collection.c:77
#4  0x00005555555fa2b4 in on_base_added (base=0x5555558de0a0, obj=0x555555da12c0, user_data=0x5555558deca0) at libseahorse/seahorse-collection.c:107
#5  0x00007ffff6064f75 in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
    [...]
(gdb) up
#1  0x000055555560676b in check_object_type (object=0x555555da12c0, user_data=0x0) at libseahorse/seahorse-search-provider.c:488
488                     if (g_strcmp0 (schema_name, "org.gnome.keyring.Note") != 0)
(gdb) print schema_name
$2 = 0x2 <error: Cannot access memory at address 0x2>

This was fixed upstream, I confirm that this patch fixes the problem:

   https://gitlab.gnome.org/GNOME/libsecret/commit/5a217c5cae721afef1273e3d272552e467f7440e

Regards,

Berto

-- System Information:
Debian Release: 9.8
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libsecret-1-0 depends on:
ii  libc6             2.24-11+deb9u4
ii  libgcrypt20       1.7.6-2+deb9u3
ii  libglib2.0-0      2.50.3-2
ii  libsecret-common  0.18.5-3.1

libsecret-1-0 recommends no packages.

libsecret-1-0 suggests no packages.

-- no debconf information