Bug#929915: vala: debian/rules: simplify parallel build

Helmut Grohne helmut at subdivi.de
Mon Jun 3 05:11:55 BST 2019


Source: vala
Version: 0.42.5-1
Severity: wishlist
Tags: patch

While looking into the vala package, I noticed that it bears unnecessary
complexity for running the bootstrap build. Using dh_auto_* works there
and removes the need for computing DEB_MAKE_PARALLEL. I've attached a
patch to demonstrate that. If you don't like the patch, please close
this bug anyway.

Helmut
-------------- next part --------------
diff --minimal -Nru vala-0.42.5/debian/changelog vala-0.42.5/debian/changelog
--- vala-0.42.5/debian/changelog	2019-01-22 18:07:20.000000000 +0100
+++ vala-0.42.5/debian/changelog	2019-06-02 20:48:44.000000000 +0200
@@ -1,3 +1,10 @@
+vala (0.42.5-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Simplify parallelity using more dh_auto_*. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sun, 02 Jun 2019 20:48:44 +0200
+
 vala (0.42.5-1) unstable; urgency=medium
 
   * New upstream release
diff --minimal -Nru vala-0.42.5/debian/rules vala-0.42.5/debian/rules
--- vala-0.42.5/debian/rules	2019-01-22 18:07:20.000000000 +0100
+++ vala-0.42.5/debian/rules	2019-06-02 20:48:44.000000000 +0200
@@ -4,13 +4,6 @@
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,-O1 -Wl,-z,defs -Wl,--as-needed
 export DEB_CFLAGS_MAINT_APPEND = -Wall
 
-DEB_PARALLEL_JOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
-ifneq (,$(DEB_PARALLEL_JOBS))
-DEB_MAKE_PARALLEL = -j$(DEB_PARALLEL_JOBS)
-else
-DEB_MAKE_PARALLEL =
-endif
-
 %:
 	dh $@ --with gnome
 
@@ -27,8 +20,8 @@
 	dh_auto_configure --builddirectory=bootstrap/build
 
 bootstrap: configure-bootstrap
-	make $(DEB_MAKE_PARALLEL) -C bootstrap/build
-	make $(DEB_MAKE_PARALLEL) -C bootstrap/build DESTDIR=$(CURDIR)/bootstrap/install install
+	dh_auto_build --builddirectory=bootstrap/build
+	dh_auto_install --builddirectory=bootstrap/build -- DESTDIR=$(CURDIR)/bootstrap/install
 
 override_dh_auto_configure: bootstrap
 	find -name '*.vala.stamp' -delete


More information about the pkg-gnome-maintainers mailing list