Bug#836355: libglib2.0-0: makes all entries of fstab show up as desktop items

[Simon McVittie]

On Fri, 07 Jun 2019 at 15:56:34 +0200, Adam Borowski wrote:
> Control: found -1 2.58.3-2

Sorry, I hadn't seen the context of Scott's mail being a reply to a
pre-existing bug, and his mails sounded as though he was opening a new
bug discussing an issue that he had encountered elsewhere but could not
reproduce in Debian.

> Besides the expected "Home" and "File System" I get two extra entries:
> * "Filesystem root" (/, redundant with "File System")
> * "boot" (/boot)
> both of which are on a non-removable disk.
> 
> New installs don't have /proc in their fstabs, but old do -- and I just
> added such an entry to mine, and indeed it did show up.

The interaction between the GIO mounts/volumes API and
GUIs is not entirely straightforward, but I believe the
way these are meant to get excluded is by being flagged as
"system-internal" (g_unix_is_mount_path_system_internal(),
g_unix_mount_is_system_internal()). Whether to display or otherwise do
something with system-internal mounts is a UI decision - I would expect
that most UI designers would want to hide system-internal mounts, but
components that are listing mounts for some other reason (like displaying
used/free space or implementing the freedesktop.org Trash spec) will
want to consider all of them.

What environment are you reproducing this on? Is it still whatever part
of XFCE is responsible for icons on the desktop, as in the original bug
report? Your image attachment doesn't seem to have made it to the bug,
so I can't tell from that. Also, are you logged in to the GUI as root?
(I ask because I think there's some logic to ignore or not ignore volumes
based on uid and home directory, so it matters - bakhelit mentioned
running thunar as root.)

I'll try to put together a script to dump the information available from
GIO, so that we can see where the information is getting lost - between
the OS and GIO, or between GIO and whichever GUI is the relevant one.

    smcv