Bug#923679: libglib2.0-0: gettext-desktopfiles patches cause memory leak

[Tim Newby]

Package: libglib2.0-0
Version: 2.56.3-0ubuntu0.18.04.1
Severity: normal

Dear Maintainer,

The patches '01-gettext-desktopfiles.patch' and '02-gettext-desktopfiles-
ubuntu.patch'
cause a memory leak as the fcn 'g_key_file_load_from_file' calls the fcn
'g_key_file_load_from_fd'
This causes a leak of memory allocated for string 'key_file->gettext_domain'.

Because 'g_key_file_load_from_file' calls the fcn 'g_key_file_load_from_fd' the
patch code
modifying 'key_file->gettext_domain' should probably ONLY be located in
'g_key_file_load_from_fd'?

The '01-gettext-desktopfiles.patch' actually causes the leak as in both the
mentioned fcns
we have

   key_file->gettext_domain = g_key_file_get_string (key_file,
                        G_KEY_FILE_DESKTOP_GROUP,
                        G_KEY_FILE_DESKTOP_KEY_GETTEXT_DOMAIN,
                        NULL);

A possible fix would be to change both patches to only apply modified code to
fcn 'g_key_file_load_from_fd'?



-- System Information:
Debian Release: buster/sid
  APT prefers bionic-updates
  APT policy: (500, 'bionic-updates'), (500, 'bionic-security'), (500, 'bionic-backports'), (500, 'bionic')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-45-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libglib2.0-0 depends on:
ii  libc6        2.27-3ubuntu1
ii  libffi6      3.2.1-8
ii  libmount1    2.31.1-0.4ubuntu3.3
ii  libpcre3     2:8.39-9
ii  libselinux1  2.7-2build2
ii  zlib1g       1:1.2.11.dfsg-0ubuntu2

Versions of packages libglib2.0-0 recommends:
ii  libglib2.0-data   2.56.3-0ubuntu0.18.04.1
ii  shared-mime-info  1.9-2
ii  xdg-user-dirs     0.17-1ubuntu1

libglib2.0-0 suggests no packages.

-- no debconf information