Bug#942119: libproxy: depends on mono for build-arch; mono not universally present

[Simon McVittie]

On Thu, 10 Oct 2019 at 12:46:22 -0400, Jeremy Bicha wrote:
> On Thu, Oct 10, 2019 at 12:09 PM Thorsten Glaser <t.glaser at tarent.de> wrote:
> > src:libproxy recently gained a B-D-Arch on dh-sequence-cli
...
> > Please use mono only in B-D-Indep.
> 
> dh-sequence-cli doesn't work in B-D-Indep as I found when I built 0.4.15-6 :
> 
> https://buildd.debian.org/status/logs.php?pkg=libproxy&arch=arm64
> 
> Is it a debhelper bug that it doesn't look like dh-sequence-* packages
> work in B-D-Indep?

debhelper's changelog says

  * dh: Support running addons in "arch-only" or "indep-only" mode by
    adding "dh-sequence-ADDON" in Build-Depends-Arch or
    Build-Depends-Indep (respectively).  Not all addons support this and
    will trigger an error at load time.

So... maybe it's a debhelper bug, or maybe it's a dh-sequence-cli bug?

In this case I would personally suggest going back to explicitly using
"--with cli" if and only if the C# parts are being built, instead of
implicitly via dh-sequence-cli.

d/rules:
> ifneq (,$(wildcard /usr/share/perl5/Debian/Debhelper/Sequence/cli.pm))
> ifeq (,$(filter stage1,$(DEB_BUILD_PROFILES)))

This sort of thing is usually better written in terms of what packages
we want to build, like in this case

DH_ADDONS =
ifneq ($(filter libproxy0.4-cil,$(DO_PACKAGES)),)
WITH_DOTNET = -DWITH_DOTNET=ON
DH_ADDONS += --with cli
else
WITH_DOTNET = -DWITH_DOTNET=OFF
endif

%:
	dh $@ $(DH_ADDONS)

We can still use dh-sequence-ADDON for the rest.

    smcv