Bug#956165: gnome-shell-extension-workspaces-to-dock: please check compatibility with GNOME Shell 3.36.x
Simon McVittie
smcv at debian.org
Wed Apr 8 01:42:30 BST 2020
Package: gnome-shell-extension-workspaces-to-dock
Version: 52-1
Severity: important
Tags: bullseye sid upstream
Control: block 954422 by -1
Forwarded: https://github.com/passingthru67/workspaces-to-dock/issues/189
GNOME Shell 3.36.x is currently in experimental, and should hopefully
be heading to unstable soon. Please check whether this extension is
compatible. From the upstream issue linked above, it seems the answer
is "no, but there's a branch that might be".
You'll probably want to add a Recommends or even Depends on
gnome-shell-extension-prefs, a new package split out from gnome-shell that
is meant to be taking over responsibility for enabling and disabling
extensions from gnome-tweaks (at the moment they both offer this,
but there's a gnome-tweaks merge request open to remove the duplicate
functionality).
One thing that is definitely not compatible is that this extension runs:
Util.spawn(["gnome-shell-extension-prefs", Me.metadata.uuid]);
This is no longer supported since GNOME Shell 3.36.1:
gnome-shell-extension-prefs no longer takes a UUID as a command-line
argument. Some of the Debian GNOME team have wondered whether it's
feasible to patch back in, but the code involved is surprisingly
extensive, so the answer might be no.
As far as I can tell from GNOME Shell's upstream commit history, the
preferred way to launch extension preferences in sufficiently recent
versions is to call imports.misc.extensionUtils.openPrefs(), which
was added by gnome-shell!1163. It isn't in 3.36.1, but the version
in experimental (which is halfway between upstream 3.36.1 and 3.36.2)
does have it.
To support older GNOME versions, fall back to the spawn call if
imports.misc.extensionUtils doesn't have an openPrefs method.
Sample code:
https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator/pull/203
Thanks,
smcv
More information about the pkg-gnome-maintainers
mailing list