Bug#951989: gnome-calculator: FTBFS: ../lib/math-equation.vala:829.53-829.56: error: Argument 1: Cannot pass value to reference or output parameter

[Lucas Nussbaum]

Source: gnome-calculator
Version: 3.34.1-1
Severity: serious
Justification: FTBFS on amd64
Tags: buster sid
Usertags: ftbfs-20200222 ftbfs-buster

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> [7/115] cc -Igcalc/35aae3b@@gcalc-1 at sha -Igcalc -I../gcalc -I. -I../ -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/libsoup-2.4 -I/usr/include/gee-0.8 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -w -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -include /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/gcalc/config.h -MD -MQ 'gcalc/35aae3b@@gcalc-1 at sha/meson-generated_gcalc-constant.c.o' -MF 'gcalc/35aae3b@@gcalc-1 at sha/meson-generated_gcalc-constant.c.o.d' -o 'gcalc/35aae3b@@gcalc-1 at sha/meson-generated_gcalc-constant.c.o' -c 'gcalc/35aae3b@@gcalc-1 at sha/gcalc-constant.c'
> [8/115] valac -C --pkg posix --pkg posix /<<PKGBUILDDIR>>/vapi/mpfr.vapi /<<PKGBUILDDIR>>/vapi/mpc.vapi --pkg libxml-2.0 --pkg libsoup-2.4 --pkg gtksourceview-4 --pkg gtk+-3.0 --pkg gobject-2.0 --target-glib ' 2.40.0' --pkg glib-2.0 --pkg gio-2.0 --color=always --directory lib/76b5a35@@calculator at sta --basedir ../lib --library calculator --header lib/calculator.h --vapi ../calculator.vapi --target-glib 2.40.0 ../lib/currency.vala ../lib/equation.vala ../lib/equation-lexer.vala ../lib/equation-parser.vala ../lib/financial.vala ../lib/function-manager.vala ../lib/math-equation.vala ../lib/math-function.vala ../lib/math-variables.vala ../lib/number.vala ../lib/serializer.vala ../lib/unit.vala gcalc/mpfrg.vapi
> FAILED: lib/76b5a35@@calculator at sta/currency.c lib/76b5a35@@calculator at sta/equation.c lib/76b5a35@@calculator at sta/equation-lexer.c lib/76b5a35@@calculator at sta/equation-parser.c lib/76b5a35@@calculator at sta/financial.c lib/76b5a35@@calculator at sta/function-manager.c lib/76b5a35@@calculator at sta/math-equation.c lib/76b5a35@@calculator at sta/math-function.c lib/76b5a35@@calculator at sta/math-variables.c lib/76b5a35@@calculator at sta/number.c lib/76b5a35@@calculator at sta/serializer.c lib/76b5a35@@calculator at sta/unit.c lib/calculator.h lib/calculator.vapi 
> valac -C --pkg posix --pkg posix /<<PKGBUILDDIR>>/vapi/mpfr.vapi /<<PKGBUILDDIR>>/vapi/mpc.vapi --pkg libxml-2.0 --pkg libsoup-2.4 --pkg gtksourceview-4 --pkg gtk+-3.0 --pkg gobject-2.0 --target-glib ' 2.40.0' --pkg glib-2.0 --pkg gio-2.0 --color=always --directory lib/76b5a35@@calculator at sta --basedir ../lib --library calculator --header lib/calculator.h --vapi ../calculator.vapi --target-glib 2.40.0 ../lib/currency.vala ../lib/equation.vala ../lib/equation-lexer.vala ../lib/equation-parser.vala ../lib/financial.vala ../lib/function-manager.vala ../lib/math-equation.vala ../lib/math-function.vala ../lib/math-variables.vala ../lib/number.vala ../lib/serializer.vala ../lib/unit.vala gcalc/mpfrg.vapi
> ../lib/math-equation.vala:327.21-327.51: warning: Access to possible `null'. Perform a check or use an unsafe cast.
>                     (this as Gtk.TextBuffer).insert (ref iter, serializer.get_thousands_separator ().to_string (), -1);
>                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> ../lib/math-equation.vala:829.17-829.50: warning: Access to possible `null'. Perform a check or use an unsafe cast.
>                 (this as Gtk.TextBuffer).backspace (iter, true, true);
>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> ../lib/math-equation.vala:829.53-829.56: error: Argument 1: Cannot pass value to reference or output parameter
>                 (this as Gtk.TextBuffer).backspace (iter, true, true);
>                                                     ^^^^
> ../lib/math-equation.vala:843.17-843.50: warning: Access to possible `null'. Perform a check or use an unsafe cast.
>                 (this as Gtk.TextBuffer).backspace (iter, true, true);
>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> ../lib/math-equation.vala:843.53-843.56: error: Argument 1: Cannot pass value to reference or output parameter
>                 (this as Gtk.TextBuffer).backspace (iter, true, true);
>                                                     ^^^^
> ../lib/math-equation.vala:857.17-857.50: warning: Access to possible `null'. Perform a check or use an unsafe cast.
>                 (this as Gtk.TextBuffer).backspace (iter, true, true);
>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> ../lib/math-equation.vala:857.53-857.56: error: Argument 1: Cannot pass value to reference or output parameter
>                 (this as Gtk.TextBuffer).backspace (iter, true, true);
>                                                     ^^^^
> ../lib/math-equation.vala:1306.13-1306.46: warning: Access to possible `null'. Perform a check or use an unsafe cast.
>             (this as Gtk.TextBuffer).backspace (iter, true, true);
>             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> ../lib/math-equation.vala:1306.49-1306.52: error: Argument 1: Cannot pass value to reference or output parameter
>             (this as Gtk.TextBuffer).backspace (iter, true, true);
>                                                 ^^^^
> Compilation failed: 4 error(s), 5 warning(s)
> [9/115] cc -Igcalc/35aae3b@@gcalc-1 at sha -Igcalc -I../gcalc -I. -I../ -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/libsoup-2.4 -I/usr/include/gee-0.8 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -w -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -include /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/gcalc/config.h -MD -MQ 'gcalc/35aae3b@@gcalc-1 at sha/meson-generated_gcalc-expression.c.o' -MF 'gcalc/35aae3b@@gcalc-1 at sha/meson-generated_gcalc-expression.c.o.d' -o 'gcalc/35aae3b@@gcalc-1 at sha/meson-generated_gcalc-expression.c.o' -c 'gcalc/35aae3b@@gcalc-1 at sha/gcalc-expression.c'
> [10/115] /usr/bin/meson --internal msgfmthelper ../data/org.gnome.Calculator.desktop.in data/org.gnome.Calculator.desktop desktop /<<PKGBUILDDIR>>/po
> [11/115] /usr/bin/meson --internal msgfmthelper ../data/org.gnome.Calculator.appdata.xml.in data/org.gnome.Calculator.appdata.xml xml /<<PKGBUILDDIR>>/po
> ninja: build stopped: subcommand failed.
> dh_auto_build: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j4 -v returned exit code 1
> make: *** [debian/rules:7: binary] Error 25

The full build log is available from:
   http://qa-logs.debian.net/2020/02/22/gnome-calculator_3.34.1-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.