Bug#970356: libvte-2.91-0: vte_terminal_spawn_async doesn't accept NULL callback since 0.62

[Axel Beckert]

Control: clone -1 -2
Control: unmerge -2
Control: reopen -2
Control: reassign -2 mssh 2.2-5
Control: severity -2 minor
Control: tag -2 = upstream
Control: retitle -2 mssh: Should use a non-NULL callback in vte_terminal_spawn_async()

Dear Simon,

Simon McVittie wrote:
> I would recommend making mssh use a non-NULL callback *anyway*, because
> it's the only way for vte_terminal_spawn_async() to report errors, which
> any non-trivial vte user should be reporting in some way. Something like
> this should be suitable:
> 
> static void
> terminal_spawn_async_cb (VteTerminal *terminal,
>                          GPid pid,
>                          GError *error,
>                          gpointer user_data)
> {
>   if (error != NULL)
>     g_critical ("Error setting up terminal: %s", error->message);
>   else
>     g_debug ("Terminal set up, process ID: %d", pid);
> }
> 
> (Or whatever error handling mssh wants to do instead of complaining on
> stderr: for example, it might want to emit the session-closed signal
> on errors, or something like that.)

Simon McVittie wrote:
> Control: reassign 970356 libvte-2.91-0 0.62.0-1
[...]
> On Wed, 30 Sep 2020 at 15:22:37 +0100, Simon McVittie wrote:
> > I've reported that upstream.
> 
> Now fixed upstream. I'll upload a fixed version soon.

Thanks, much appreciated!

> mssh should ideally still use a non-NULL callback here so that it can
> have better error reporting, but that isn't RC.

I just don't understand why you reassigned that bug then instead of
e.g. cloning or even just simply downgrading it.

Cloning it now and reassigning the clone back — now with severity
minor and a suitable title to keep this at a place where it will be
remembered until its fixed.

P.S.: I have no idea how the BTS behaves when cloning a merged bug. If
I get two cloned bugs in the end, then sorry in advance for that mess.
Will probably have to clean up something afterwards anyways, I just
don't know yet what. Tried to guess as much as possible of what's
needed in the mess we already have here. ;-)

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE