Bug#978176: gimp: FTBFS: dh_install: error: missing files, aborting

[Andreas Henriksson]

Control: reassign -1 libheif-dev 1.10.0-1
Control: retitle -1 libheif-dev missing dependencies on pkg-config Requires.private listed components
Control: affects -1 gimp

Hello,

It seems like the recently uploaded libheif 1.10 is broken causing
problems for gimp (and all other reverse dependencies using
libheif.pc ?!). Thus reassigning, more details below.

On Sat, Dec 26, 2020 at 10:13:50PM +0100, Lucas Nussbaum wrote:
> Source: gimp
> Version: 2.10.22-2
> Severity: serious
> Justification: FTBFS on amd64
> Tags: bullseye sid ftbfs
> Usertags: ftbfs-20201226 ftbfs-bullseye
> 
> Hi,
> 
> During a rebuild of all packages in sid, your package failed to build
> on amd64.
> 
> Relevant part (hopefully):
> > make[1]: Entering directory '/<<PKGBUILDDIR>>'
[...]
> > dh_install: warning: Cannot find (any matches for) "usr/lib/gimp/2.0/plug-ins/file-heif" (tried in ., debian/tmp)
> > 
> > dh_install: warning: gimp missing files: usr/lib/gimp/2.0/plug-ins/file-heif
> > dh_install: error: missing files, aborting
> > make[1]: *** [debian/rules:44: override_dh_install] Error 25
> 
> The full build log is available from:
>    http://qa-logs.debian.net/2020/12/26/gimp_2.10.22-2_unstable.log
[...]


In the full build log it can be seen that no version of libheif
is detected by configure despite the libheif-dev being installed
as part of build-dependencies.

This can be seen in config.log:

```
configure:29056: checking for libheif > 1.5.1
configure:29063: $PKG_CONFIG --exists --print-errors "libheif > 1.5.1"
Package aom was not found in the pkg-config search path.
Perhaps you should add the directory containing `aom.pc'
to the PKG_CONFIG_PATH environment variable
Package 'aom', required by 'libheif', not found
configure:29066: $? = 1
configure:29080: $PKG_CONFIG --exists --print-errors "libheif > 1.5.1"
Package aom was not found in the pkg-config search path.
Perhaps you should add the directory containing `aom.pc'
to the PKG_CONFIG_PATH environment variable
Package 'aom', required by 'libheif', not found
configure:29083: $? = 1
configure:29097: result: no
Package 'aom', required by 'libheif', not found
configure:29116: checking for libheif = 1.4.0
configure:29123: $PKG_CONFIG --exists --print-errors "libheif = 1.4.0"
Package aom was not found in the pkg-config search path.
Perhaps you should add the directory containing `aom.pc'
to the PKG_CONFIG_PATH environment variable
Package 'aom', required by 'libheif', not found
configure:29126: $? = 1
configure:29140: $PKG_CONFIG --exists --print-errors "libheif = 1.4.0"
```

New in libheif 1.10 (currently in unstable) is that the libheif.pc
pkg-config file has:

```
> grep Requires usr/lib/*/pkgconfig/libheif.pc
Requires:
Requires.private:  aom libde265 x265
```

This was not the case in libheif 1.9 (currently in testing).

The pkg-config file is thus broken when installing libheif-dev in
a clean system where the pkg-config files of aom, etc are not installed.

As far as I can tell the fix is:
a/ Add libaom-dev, libde265-dev and libx265-dev to Depends of libheif-dev
b/ preferably also write a simple autopkgtest that checks if libheif.pc
   works as expected....
   eg. `pkg-config --exists --print-errors "libheif > 1.5.1"` should
   not error out when libheif-dev is installed.

Regards,
Andreas Henriksson